Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a full-featured serializer from a qiskit.QuantumCircuit to a quantum-viz.js JSON #44

Merged
merged 109 commits into from
May 27, 2022
Merged

Add a full-featured serializer from a qiskit.QuantumCircuit to a quantum-viz.js JSON #44

merged 109 commits into from
May 27, 2022

Conversation

jond01
Copy link
Contributor

@jond01 jond01 commented Oct 29, 2021 •
edited
Loading

Description

  • Resolves Qiskit support #37.
  • Dependencies that are required for this change: qiskit-terra, added as an optional dependency to the Python package.
    Installable with: 
    pip install -U "quantum-viz[qiskit]"

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

  • Manual tests and examples
  • Automatic tests - run them with nox -s tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@jond01 jond01 force-pushed the feature/qiskit branch 3 times, most recently from 94ad6b5 to e8f51d8 Compare November 1, 2021 22:41
atching and others added 25 commits November 4, 2021 15:51
@atching @jond01
Add qiskit python parser. (microsoft#35)
5d11ab2 
Initial commit of a parser for IBM Qiskit quantum circuits to output to json file compatible with Quantum-Viz.
@jond01
Move qiskit_parser contents to quantum_viz
92e05af 
Rename and reformat the files
@jond01
Change qiskit_parser functions interface
a8aa6c1
@jond01
Add a basic QiskitCircuitParser class
39f16fa
@jond01
Add a utils module to display the parser result
4b7ca4b
@jond01
Add parse_operation method
0617867
@jond01
Support instruction params through displayArgs
0baddd0
@jond01
Support controlled gates
63c9c76 
"isControlled"
@jond01
Small fixes in measurement operation
53795ec
@jond01
Uppercase X and SWAP to benefit from gate visualizations
01da871
@jond01
Capitalize or uppercase some gate names
57c7e2d
@jond01
Replace the old code with QiskitCircuitParser
ef416c9 
All the previous functionality is implemented
@jond01
Add RegisterType and ConditionalRender int enums
350f84e
@jond01
Support measurements
7c310db 
Add logic for storing identifiers for qubits and classical bits
@jond01
Support children operations through naive recursion
8616373 
Works for circuits with a single qubit
@jond01
Uppercase the U gate
6377e15
@jond01
Update the example to a single swap gate
96d7657 
It works
@jond01
Revert "Update the example to a single swap gate"
b266d24 
This reverts commit 36e9c13.
@jond01
Support recursion with updated sub qargs and cargs
e2cae1a
@jond01
Remove unused imports
33861f9
@jond01
Update uppercase list
c886cbf 
Add P and R gates
@jond01
Set isAdjoint to true for "dg" qiskit's gates
539d8c3 
TdgGate, SdgGate, SXdgGate
@jond01
Revert last commit - this is not the intent of isAdjoint
eebe1d4 
These gates are already adjoints - no need to add `'`
@jond01
Fix the args of the children operations
151d706 
Use the indices, hopefully that's enough
@jond01
Add new rules for gate naming
4e269e4 
See
https://qiskit.org/documentation/stubs/qiskit.visualization.qcstyle.DefaultStyle.html#qiskit.visualization.qcstyle.DefaultStyle

https://github.com/Qiskit/qiskit-terra/blob/c347614f2aad1652ac1fe431d4ab11f11530d49b/qiskit/visualization/text.py#L862
@anpaz anpaz mentioned this pull request Dec 3, 2021
Closed
12 tasks
anpaz
anpaz requested changes Dec 3, 2021
View reviewed changes
quantum-viz/quantum_viz/qiskit_parser.py Outdated Show resolved Hide resolved
quantum-viz/examples/Qiskit.ipynb Show resolved Hide resolved
quantum-viz/examples/display_example.py Show resolved Hide resolved
quantum-viz/quantum_viz/qiskit_parser.py Show resolved Hide resolved
quantum-viz/quantum_viz/qiskit_parser.py Outdated Show resolved Hide resolved
quantum-viz/quantum_viz/qiskit_parser.py Show resolved Hide resolved
quantum-viz/quantum_viz/utils.py Show resolved Hide resolved
quantum-viz/quantum_viz/utils.py Show resolved Hide resolved
quantum-viz/tests/conftest.py Show resolved Hide resolved
quantum-viz/tests/test_qiskit_generate_results.py Outdated Show resolved Hide resolved
@anpaz
Copy link
Member

anpaz commented Dec 3, 2021

This is a great contribution. Thank you @jond01 for it! There are a few things that we need to clean up, otherwise looks great.
I'm also going to send a PR against your repo with a new notebook sample and a bug fix for the Viewer. But again, looks great!

@jond01 jond01 mentioned this pull request Jan 19, 2022
Merged
9 tasks
@jond01 jond01 changed the title Add a full-featured parser from a qiskit.QuantumCircuit to a quantum-viz.js json Add a full-featured serializer from a qiskit.QuantumCircuit to a quantum-viz.js json May 20, 2022
@jond01 jond01 changed the title Add a full-featured serializer from a qiskit.QuantumCircuit to a quantum-viz.js json Add a full-featured serializer from a qiskit.QuantumCircuit to a quantum-viz.js JSON May 20, 2022
@anpaz
Copy link
Member

anpaz commented May 20, 2022

sigh... @jond01, our new CI checks caught a lot of small things, like docstrings and coverage, if you have time could you add them? otherwise I'll try to get this done early next week.

@anpaz
Copy link
Member

anpaz commented May 27, 2022

We'll merge the fixes to CI pipeline on the next commit.

@anpaz anpaz enabled auto-merge (squash) May 27, 2022 04:52
@anpaz anpaz disabled auto-merge May 27, 2022 04:54
@anpaz anpaz merged commit 0a3f572 into microsoft:main May 27, 2022
@anpaz anpaz mentioned this pull request May 27, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anpaz anpaz anpaz requested changes

@guenp guenp guenp approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Qiskit support
5 participants
@jond01 @codecov-commenter @guenp @anpaz @atching