Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

browser(webkit): don't leak pages on window.open #1261

Merged
merged 1 commit into from
Mar 6, 2020
Merged

browser(webkit): don't leak pages on window.open #1261

merged 1 commit into from
Mar 6, 2020

Conversation

JoelEinbinder
Copy link
Contributor

@JoelEinbinder JoelEinbinder commented Mar 6, 2020 •
edited
Loading

webkitWebViewCreateNewPage returns a WebPageProxy* that is owned by the caller. completionHandler takes a RefPtr<WebPageProxy>. Previously, this code was implictly constructing a new RefPtr. However it needs to use adoptRef instead, as it owns the raw WebPageProxy* pointer.

This impacts WPE and GTK.

JoelEinbinder/webkit@71dbb9f

@JoelEinbinder JoelEinbinder requested a review from yury-s March 6, 2020 08:02
@pavelfeldman
Copy link
Member

Upstream it right away?

@pavelfeldman pavelfeldman merged commit 9c80c9e into microsoft:master Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelfeldman pavelfeldman pavelfeldman approved these changes

@yury-s yury-s Awaiting requested review from yury-s

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoelEinbinder @pavelfeldman