fix: don't leak pages on window.open

JoelEinbinder · JoelEinbinder · commit 71dbb9f290c5 · 2020-03-05T23:52:46.000-08:00
diff --git a/Source/WebKit/UIProcess/API/glib/WebKitUIClient.cpp b/Source/WebKit/UIProcess/API/glib/WebKitUIClient.cpp
@@ -64,7 +64,8 @@ class UIClient : public API::UIClient {
     void createNewPage(WebPageProxy& page, WebCore::WindowFeatures&& windowFeatures, Ref<API::NavigationAction>&& apiNavigationAction, CompletionHandler<void(RefPtr<WebPageProxy>&&)>&& completionHandler) final
     {
         WebKitNavigationAction navigationAction(WTFMove(apiNavigationAction));
-        completionHandler(webkitWebViewCreateNewPage(m_webView, windowFeatures, &navigationAction));
+        WebPageProxy* newPage = webkitWebViewCreateNewPage(m_webView, windowFeatures, &navigationAction);
+        completionHandler(adoptRef(newPage));
     }
 
     void showPage(WebPageProxy*) final

Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,8 @@ class UIClient : public API::UIClient {`
`64`	`64`	`void createNewPage(WebPageProxy& page, WebCore::WindowFeatures&& windowFeatures, Ref<API::NavigationAction>&& apiNavigationAction, CompletionHandler<void(RefPtr<WebPageProxy>&&)>&& completionHandler) final`
`65`	`65`	`{`
`66`	`66`	`WebKitNavigationAction navigationAction(WTFMove(apiNavigationAction));`
`67`		`- completionHandler(webkitWebViewCreateNewPage(m_webView, windowFeatures, &navigationAction));`
	`67`	`+ WebPageProxy* newPage = webkitWebViewCreateNewPage(m_webView, windowFeatures, &navigationAction);`
	`68`	`+ completionHandler(adoptRef(newPage));`
`68`	`69`	`}`
`69`	`70`
`70`	`71`	`void showPage(WebPageProxy*) final`