upgrade protobuf to 3.20.2 and onnx to 1.13 #14279

mszhanyi · 2023-01-13T04:04:24Z

Description

upgrade protobuf to 3.20.2, same as onnx 1.13.0

Motivation and Context

Per component governance requirement and Fixes #14060

unused-parameter error occurs in 2 conditions.

compile protolbuf
onnxruntime_src/cmake/external/protobuf/src/google/protobuf/repeated_ptr_field.h:752:66: error: unused parameter ‘prototype’ [-Werror=unused-parameter]
include onnx_pb.h

2023-01-28T10:20:15.0410853Z FAILED: CMakeFiles/onnxruntime_pybind11_state.dir/onnxruntime_src/onnxruntime/python/onnxruntime_pybind_iobinding.cc.o 
......
2023-01-28T10:20:15.0466024Z                  from /build/Debug/_deps/onnx-src/onnx/onnx_pb.h:51,
2023-01-28T10:20:15.0466958Z                  from /onnxruntime_src/include/onnxruntime/core/framework/to_tensor_proto_element_type.h:10,
....
2023-01-28T10:20:15.0609678Z /build/Debug/_deps/onnx-build/onnx/onnx-operators-ml.pb.h:1178:25:   required from here
2023-01-28T10:20:15.0610895Z /onnxruntime_src/cmake/external/protobuf/src/google/protobuf/repeated_ptr_field.h:752:66: error: unused parameter ‘prototype’ [-Werror=unused-parameter]
2023-01-28T10:20:15.0611707Z cc1plus: all warnings being treated as errors

https://dev.azure.com/onnxruntime/2a773b67-e88b-4c7f-9fc0-87d31fea8ef2/_apis/build/builds/874605/logs/22

mszhanyi · 2023-01-13T04:05:10Z

@snnn, how did you get the sha1. I calculated locally.

edgchen1 · 2023-01-13T18:12:19Z

tools/ci_build/github/linux/docker/scripts/requirements.txt

why is this one different?

thx. fixed.

cmake/deps.txt

snnn · 2023-01-15T20:21:07Z

@snnn, how did you get the sha1. I calculated locally.

Use "C:\Program Files\git\usr\bin\sha1sum.exe" .

…zhanyi/updateprotobuf

snnn · 2023-01-27T16:25:05Z

cmake/CMakeLists.txt

-      endif()
+      # external/protobuf/src/google/protobuf/arena.h:445:18: error: unused parameter 'p'
+      # onnxruntime_src/cmake/external/protobuf/src/google/protobuf/repeated_ptr_field.h:752:66: error: unused parameter ‘prototype’ [-Werror=unused-parameter]
+      target_compile_options(${target_name} PRIVATE "-Wno-unused-parameter")


I think it is better to only disable the warning for protobuf related code. If you add the compile flag here, our code will start to have such warnings(though they are suppressed).

There're 2 types of errors caused by this _unused-parameter . More exception info is in the description of this PR.

compiling protobuf source code. The scope could be easily narrowed by updating the patch or other solution.

source code which include onnx/onnx_pb.h.
So far, there're 44 c++ and 4 Objective-c files include the header.

So, I've patched ONNX directly. @snnn

mszhanyi · 2023-01-31T01:40:03Z

@pranavsharma @yuslepukhin do you have any more comments?

This reverts commit 80f807c.

### Description upgrade protobuf to 3.20.2, same as onnx 1.13.0 ### Motivation and Context Per component governance requirement and Fixes #14060 unused-parameter error occurs in 2 conditions. 1. compile protolbuf `onnxruntime_src/cmake/external/protobuf/src/google/protobuf/repeated_ptr_field.h:752:66: error: unused parameter ‘prototype’ [-Werror=unused-parameter]` 2. include onnx_pb.h ``` 2023-01-28T10:20:15.0410853Z FAILED: CMakeFiles/onnxruntime_pybind11_state.dir/onnxruntime_src/onnxruntime/python/onnxruntime_pybind_iobinding.cc.o ...... 2023-01-28T10:20:15.0466024Z from /build/Debug/_deps/onnx-src/onnx/onnx_pb.h:51, 2023-01-28T10:20:15.0466958Z from /onnxruntime_src/include/onnxruntime/core/framework/to_tensor_proto_element_type.h:10, .... 2023-01-28T10:20:15.0609678Z /build/Debug/_deps/onnx-build/onnx/onnx-operators-ml.pb.h:1178:25: required from here 2023-01-28T10:20:15.0610895Z /onnxruntime_src/cmake/external/protobuf/src/google/protobuf/repeated_ptr_field.h:752:66: error: unused parameter ‘prototype’ [-Werror=unused-parameter] 2023-01-28T10:20:15.0611707Z cc1plus: all warnings being treated as errors ``` https://dev.azure.com/onnxruntime/2a773b67-e88b-4c7f-9fc0-87d31fea8ef2/_apis/build/builds/874605/logs/22

pacowong · 2023-02-09T16:20:35Z

It would be great if the library can upgrade to the protobuf version of 3.21.3+ earlier as I encounter a bug in this version while compiling ORT.

protocolbuffers/protobuf#9947
https://stackoverflow.com/questions/73047153/protobuf-ld-undefined-symbol-internalmetadata

mszhanyi requested review from snnn and edgchen1 January 13, 2023 04:06

upgrade protobuf

79c6d37

mszhanyi force-pushed the zhanyi/updateprotobuf branch from 0f2d1b3 to 79c6d37 Compare January 13, 2023 04:09

gcmanifest.json

a926c22

mszhanyi requested a review from a team as a code owner January 13, 2023 04:30

mszhanyi added 3 commits January 13, 2023 13:03

update

488b7f4

add one log

6e488ad

update artifacts

79e9f3b

mszhanyi requested a review from a team as a code owner January 13, 2023 07:56

mszhanyi changed the title ~~upgrade protobuf to 3.19.6~~ upgrade protobuf to 3.20.2 Jan 13, 2023

mszhanyi marked this pull request as draft January 13, 2023 09:48

update protobuf 3.20.2

b5a7f28

mszhanyi force-pushed the zhanyi/updateprotobuf branch from fc494fa to b5a7f28 Compare January 13, 2023 10:02

minor update

d73d925

edgchen1 reviewed Jan 13, 2023

View reviewed changes

snnn reviewed Jan 15, 2023

View reviewed changes

cmake/deps.txt Show resolved Hide resolved

mszhanyi added 5 commits January 16, 2023 11:10

update

3b45872

update

56f7d8d

Merge branch 'main' of https://github.com/microsoft/onnxruntime into …

aa0ea4a

…zhanyi/updateprotobuf

update cmake.patch

a92be8e

revert eigen

0dd4358

mszhanyi force-pushed the zhanyi/updateprotobuf branch from 3a4c5ad to 0dd4358 Compare January 18, 2023 10:29

mszhanyi added 4 commits January 18, 2023 22:27

fix tvm

0c1f723

fix rocm

0fb4e5d

-Wno-unused-parameter for eager

42c2f85

Merge branch 'main' of https://github.com/microsoft/onnxruntime into …

c47f71f

…zhanyi/updateprotobuf

mszhanyi force-pushed the zhanyi/updateprotobuf branch from 508d94d to 5f11e9f Compare January 19, 2023 07:20

mszhanyi requested a review from pranavsharma January 27, 2023 15:27

snnn reviewed Jan 27, 2023

View reviewed changes

revert change in cmakelist

a14f672

mszhanyi force-pushed the zhanyi/updateprotobuf branch 6 times, most recently from f860de7 to 39efc46 Compare January 28, 2023 11:57

mszhanyi requested a review from snnn January 29, 2023 00:57

mszhanyi added 3 commits January 29, 2023 12:47

update protobuf patch

96843a4

update onnx.patch

1d21267

update onnx.patch

70d671b

snnn approved these changes Jan 30, 2023

View reviewed changes

pranavsharma approved these changes Jan 31, 2023

View reviewed changes

snnn merged commit 80f807c into main Jan 31, 2023

snnn deleted the zhanyi/updateprotobuf branch January 31, 2023 20:55

rui-ren added the release:1.14 label Jan 31, 2023

faxu added the triage:approved Approved for cherrypicks for release label Feb 1, 2023

mszhanyi added a commit that referenced this pull request Feb 2, 2023

Revert "upgrade protobuf to 3.20.2 and onnx to 1.13 (#14279)"

5fe405c

This reverts commit 80f807c.

mszhanyi mentioned this pull request Feb 2, 2023

Fix python packaging pipeline #14533

Merged

faxu removed the release:1.14 label Feb 7, 2023

thiagocrepaldi mentioned this pull request Feb 8, 2023

Update ONNX submodule to support opset 18 #12879

Closed

jtilly mentioned this pull request Mar 3, 2023

onnxruntime v1.14.0 conda-forge/onnxruntime-feedstock#48

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

upgrade protobuf to 3.20.2 and onnx to 1.13 #14279

upgrade protobuf to 3.20.2 and onnx to 1.13 #14279

mszhanyi commented Jan 13, 2023 •

edited

Loading

mszhanyi commented Jan 13, 2023 •

edited

Loading

edgchen1 Jan 13, 2023

mszhanyi Jan 18, 2023

snnn commented Jan 15, 2023

snnn Jan 27, 2023

mszhanyi Jan 28, 2023 •

edited

Loading

mszhanyi Jan 29, 2023 •

edited

Loading

mszhanyi commented Jan 31, 2023 •

edited

Loading

pacowong commented Feb 9, 2023

upgrade protobuf to 3.20.2 and onnx to 1.13 #14279

upgrade protobuf to 3.20.2 and onnx to 1.13 #14279

Conversation

mszhanyi commented Jan 13, 2023 • edited Loading

Description

Motivation and Context

mszhanyi commented Jan 13, 2023 • edited Loading

edgchen1 Jan 13, 2023

Choose a reason for hiding this comment

mszhanyi Jan 18, 2023

Choose a reason for hiding this comment

snnn commented Jan 15, 2023

snnn Jan 27, 2023

Choose a reason for hiding this comment

mszhanyi Jan 28, 2023 • edited Loading

Choose a reason for hiding this comment

mszhanyi Jan 29, 2023 • edited Loading

Choose a reason for hiding this comment

mszhanyi commented Jan 31, 2023 • edited Loading

pacowong commented Feb 9, 2023

mszhanyi commented Jan 13, 2023 •

edited

Loading

mszhanyi commented Jan 13, 2023 •

edited

Loading

mszhanyi Jan 28, 2023 •

edited

Loading

mszhanyi Jan 29, 2023 •

edited

Loading

mszhanyi commented Jan 31, 2023 •

edited

Loading