-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ONNX submodule to support opset 18 #12879
Conversation
@skottmckay could you look into this one? |
c213a27
to
2a7c984
Compare
2a7c984
to
f8ea18e
Compare
@snnn This PR changes ONNX from the latest stable release to a commit. No code/dataset change, but several tests consistently failed with [E:onnxruntime:Default, provider_test_utils.cc:1045 Run] Resolve failed with status: Node (node1) Op (Resize) [ShapeInferenceError] Either `sizes` or `scales` must be provided, but not both of them
2022-10-03T18:03:46.8850993Z /onnxruntime_src/onnxruntime/test/providers/provider_test_utils.cc:1047: Failure
2022-10-03T18:03:46.8851477Z Value of: status.IsOK()
2022-10-03T18:03:46.8851741Z Actual: false
2022-10-03T18:03:46.8851984Z Expected: true
2022-10-03T18:03:46.8852340Z Node (node1) Op (Resize) [ShapeInferenceError] Either `sizes` or `scales` must be provided, but not both of them I wonder if the reason is because of the step 4 at onnxruntime/How_To_Update_ONNX_Dev_Notes.md, which states:
If that is the case, could you help updating the test data? |
It needs something like this: #13062 And your PR needs an approval from the admins of this repo. I'm not one of the admins. |
Looks like the ONNX type/shape inferencing started enforcing the Resize spec more strictly for opset 13 which is causing some of the test failures. Tests should be updated to only provide either 'scales' or 'sizes'
|
It needs an approval from @onnxruntime-admin |
Yes, @faxu mentioned it was ok to merge this post 1.13 release. |
f8ea18e
to
db56371
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be updated to the latest released version of onnx (1.13) once it's available.
Duplicate of #14279 |
This PR has the goal of updating ONNX to a particular commit and allow ORT to execute ONNX graphs with opset 18
PyTorch is about to merge the same change. However, because PyTorch depends on ORT for unit testing, ORT also must update its ONNX submodule for their pipelines to succeed. Otherwise, ORT will not recognize the new ops PyTorch ONNX converter adds, such as Col2Im