ArmPkg: CpuDxe: Fix Bad Cast #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When 2405 was done, the inexact order of rebasing caused an old commit microsoft@41c7073 to take precedence over a newer commit microsoft@38ba4a6. This causes the upper attributes to be dropped, which in the case of an invalid entry, will send 0xFFFFFFFF to be set as attributes to set in the GCD, instead of signifying an INVALID_ENTRY, because (UINT32)INVALID_ENTRY != INVALID_ENTRY. This needs to be squashed with microsoft@41c7073 on the next rebase.
kuqin12
approved these changes
Oct 10, 2024
apop5
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When 2405 was done, the inexact order of rebasing caused an old commit 41c7073 to take precedence over a newer commit 38ba4a6.
This causes the upper attributes to be dropped, which in the case of an invalid entry, will send 0xFFFFFFFF to be set as attributes to set in the GCD, instead of signifying an INVALID_ENTRY, because (UINT32)INVALID_ENTRY != INVALID_ENTRY.
How This Was Tested
On a platform where this was failing.
Integration Instructions
N/A.