Adding containment on BreadcrumbBar fixes #8330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
needs-triage
kmahone
force-pushed
the
user/bakudies/add-containment
branch
from
05ff29f to
f01973a
Compare
bkudiess
changed the title
kmahone
requested changes
Mar 29, 2023
dev/Breadcrumb/BreadcrumbBar.cpp
Outdated
| @@ -568,6 +608,54 @@ void BreadcrumbBar::OnChildPreviewKeyDown(const winrt::IInspectable&, const winr | |||
| return; | |||
| } | |||
| } | |||
| if(!Feature_Crumbs::IsEnabled()) | |||
| { | |||
| args.Handled(HandleEdgeCaseFocus(false, args.OriginalSource())); | |||
kmahone
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding containment on two cherry picked PRs:
Preventing repeater to reuse default layout #8246
Fix BreadcrumbBar KeyDown Handling #8272
Manually verified keys are working.