Fix BreadcrumbBar KeyDown Handling #8272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
needs-triage
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
RBrid
approved these changes
Mar 13, 2023
| @@ -450,7 +450,7 @@ bool BreadcrumbBar::MoveFocus(int indexIncrement) | |||
| { | |||
There was a problem hiding this comment.
I would exit early instead of doing a bunch of unneeded work when indexIncrement == 0:
if (indexIncrement == 0)
{
return false;
}
if (auto const& itemsRepeater = m_itemsRepeater.get())
{
...
bkudiess
added a commit
that referenced
this pull request
Mar 24, 2023
* Stop marking events as handled when no action is taken * Prevent focus move on Up and Down arrow (cherry picked from commit eceb90f)
bkudiess
added a commit
that referenced
this pull request
Apr 7, 2023
* Stop marking events as handled when no action is taken * Prevent focus move on Up and Down arrow (cherry picked from commit eceb90f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements on BreadcrumbBar KeyDown event handling:
HandleEdgeCaseFocuswas copied from RadioButtons, and has no real use on BreadcrumbBar, simplifing the code by removing that, which was affecting the handling of events too.