TopNavView OverFlow Items Incorrect Foreground Colour Fix #5619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
beervoley
added
area-NavigationView
ranjeshj
reviewed
Aug 10, 2021
| @@ -727,7 +727,6 @@ | |||
| <VisualState x:Name="OnTopNavigationPrimary"> | |||
| <VisualState.Setters> | |||
| <Setter Target="NavigationViewItemPresenter.Margin" Value="{ThemeResource TopNavigationViewItemMargin}"/> | |||
| <Setter Target="NavigationViewItemPresenter.Foreground" Value="{ThemeResource TopNavigationViewItemForeground}" /> | |||
There was a problem hiding this comment.
So this was set from the style below as well ? I think this line might be overwriting the TemplateBinding below which probably caused it to not revert when getting out of this state.
ranjeshj
approved these changes
Aug 10, 2021
StephenLPeters
added
the
needs-cherrypicktorelease
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove extra
NavigationViewItemPresenter.Foregroundsetter fromNavigationView.xaml.Unsure why this was the causing TopNavView items to show up as different colours as it is revealed on resize, but I hypothesize that the ordering in which
TextFillColorPrimaryBrushis being evaluated is causing issues. It is instead evaluating the System theme colour rather than the app theme colour.Motivation and Context
Fixes #5559