Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NavigationView TopNav not yet rendered OverFlow items showing up due to resizing have wrong foreground(style) after theme change #5559

Closed
beervoley opened this issue Jul 27, 2021 · 5 comments · Fixed by #5619
Assignees
Labels
area-NavigationView NavView control needs-cherrypicktorelease PR tagged for cherry-pick to the current release branch (but not yet picked) team-Controls Issue for the Controls team

Comments

@beervoley
Copy link
Contributor

beervoley commented Jul 27, 2021

Describe the bug

When I'm trying to resize the window causing Overflow items (that haven't been shown yet) in TopNav to appear in PrimaryList, the overflow items that are shown have wrong foreground (see gif attached).
It only happens if I start in Dark mode (system wide), open XCG and then change the Theme inside XCG to Light.
Steps to reproduce the bug

Steps to reproduce the behavior:

  1. Start in system wide Dark Mode.
  2. Open XCG -> change XCG theme to Light.
  3. Resize the window to smallest possible.
  4. Open Navigation View Page.
  5. Scroll to TopNav example.
  6. Resize the window to allow some Oveflow Items to move to Primary List.
  7. Observe their foreground(style).

Expected behavior

Moved from Overflow Items should have correct foreground(style) matching other items that are already rendered in the Primary List.
Screenshots

I've hovered over the elements after they become visible, that turned their foreground color to the correct one.
navview_bug

Device form factor Saw the problem?
Desktop Yes
@beervoley beervoley added the area-NavigationView NavView control label Jul 27, 2021
@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Jul 27, 2021
@beervoley
Copy link
Contributor Author

@StephenLPeters @karenbtlai FYI

@StephenLPeters
Copy link
Contributor

What causes them to populate with the right foreground?

@beervoley
Copy link
Contributor Author

beervoley commented Jul 27, 2021

I hovered over them, then they changed to proper foreground.

@StephenLPeters StephenLPeters added needs-cherrypicktorelease PR tagged for cherry-pick to the current release branch (but not yet picked) team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Jul 27, 2021
@StephenLPeters
Copy link
Contributor

This seems pretty bad to me. @beervoley do you have an idea what might be going on? I think we should get this into a servicing fix.

@karkarl karkarl self-assigned this Jul 30, 2021
@karkarl
Copy link
Contributor

karkarl commented Aug 2, 2021

@beervoley I'm unable to repro. Are you still seeing this on your machine?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-NavigationView NavView control needs-cherrypicktorelease PR tagged for cherry-pick to the current release branch (but not yet picked) team-Controls Issue for the Controls team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants