Avoid CommandBarFlyoutCommandBar clipping after dynamic command bar element change #5347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ranjeshj
added
team-Controls
llongley
requested changes
Jul 3, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Are this related to this issue? #4878 |
llongley
approved these changes
Jul 4, 2021
|
@RBrid the KeyboardAcceleratorTextOverrideProperty DP was added to AppBarButton in RS4 which explains the down level test failures. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CommandBarFlyoutCommandBar did not support dynamic changes of its secondary AppBarButton/AppBarToggleButton elements.
For instance when lengthening the Label of an element after the command bar was opened, it could get clipped on the right side. The CommandBarFlyoutCommandBar did not update its UI in response to an element dependency property change.
CommandBarFlyout is now listening to AppBarButton/AppBarToggleButton dependency property changes that may affect the desired sizing of the CommandBarFlyoutCommandBar. The change notifications are forwarded to the CommandBarFlyoutCommandBar which triggers a UI refresh only when it's already open. The template settings are refreshed and the Collapsed visual state is synchronously / momentarily visited to refresh all visual aspects.
I commented out all the debug tracing that use string literals to avoid bloating the binaries.
Updated MUXControlsTestApp to allow asynchronous Label changes and asynchronous secondary commands clearing.
Tested with MUXControlsTestApp and Windows 11.
Added new interactive regression test.