Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set AlwaysExpanded=True will cause CommandBarFlyout clipped when closing #4878

Closed
zhuxb711 opened this issue Apr 22, 2021 · 3 comments
Closed
Assignees
Labels
area-Commanding AppBar, UICommand, MVVM, etc area-UIDesign UI Design, styling no-issue-activity team-Controls Issue for the Controls team

Comments

@zhuxb711
Copy link
Contributor

Describe the bug
If I change PrimaryCommand and close CommandBarFlyout, it will clip itself.

Steps to reproduce the bug

Steps to reproduce the behavior:

  1. Set AlwaysExpaned = True
  2. Change PrimaryCommand to hidden one
  3. Close CommandBarFlyout

Expected behavior
Should close itself like it used to be.

Screenshots
I click "Copy" twice and it work well.
But if primary command changed and AlwaysExpanded is set to True. Then I found the bug.
GIF 4-22-2021 5-48-17 PM

Version Info

NuGet package version:
2.6.0-prerelease.210405001

Windows app type:

UWP Win32
Yes
Windows 10 version Saw the problem?
Insider Build (xxxxx)
October 2020 Update (19042) Yes
May 2020 Update (19041)
November 2019 Update (18363)
May 2019 Update (18362)
October 2018 Update (17763)
April 2018 Update (17134)
Fall Creators Update (16299)
Creators Update (15063)
Device form factor Saw the problem?
Desktop Yes
Xbox
Surface Hub
IoT

Additional context
Example code:

        <muxc:CommandBarFlyout x:Name="FileFlyout"
                               AlwaysExpanded="True"
                               Placement="RightEdgeAlignedTop">
            <AppBarElementContainer x:Name="FileStandardBar">
                <StackPanel Orientation="Horizontal">
                    <AppBarButton Icon="Copy"/>
                    <AppBarButton Icon="Cut" />
                    <AppBarButton Icon="Delete"/>
                    <AppBarButton Icon="Rename" />
                    <Border Background="Transparent"
                            Padding="12"
                            PointerEntered="ColorTag_PointerEntered">
                        <Viewbox>
                            <FontIcon FontFamily="{ThemeResource SymbolThemeFontFamily}"
                                      Glyph="&#xEB52;" />
                        </Viewbox>
                    </Border>
                </StackPanel>
            </AppBarElementContainer>
            <AppBarElementContainer Visibility="{x:Bind FileStandardBar.Visibility, Mode=TwoWay, Converter={StaticResource InverseConverter}}">
                <StackPanel Orientation="Horizontal">
                    <AppBarButton Name="UnTag">
                        <AppBarButton.Icon>
                            <FontIcon FontFamily="{ThemeResource SymbolThemeFontFamily}"
                                      Glyph="&#xEB51;" />
                        </AppBarButton.Icon>
                    </AppBarButton>
                    <AppBarButton Foreground="Orange">
                        <AppBarButton.Icon>
                            <FontIcon FontFamily="{ThemeResource SymbolThemeFontFamily}"
                                      Glyph="&#xEB51;" />
                        </AppBarButton.Icon>
                    </AppBarButton>
                    <AppBarButton Foreground="GreenYellow">
                        <AppBarButton.Icon>
                            <FontIcon FontFamily="{ThemeResource SymbolThemeFontFamily}"
                                      Glyph="&#xEB51;" />
                        </AppBarButton.Icon>
                    </AppBarButton>
                    <AppBarButton Foreground="Yellow">
                        <AppBarButton.Icon>
                            <FontIcon FontFamily="{ThemeResource SymbolThemeFontFamily}"
                                      Glyph="&#xEB51;" />
                        </AppBarButton.Icon>
                    </AppBarButton>
                    <AppBarButton Foreground="#409EFE">
                        <AppBarButton.Icon>
                            <FontIcon FontFamily="{ThemeResource SymbolThemeFontFamily}"
                                      Glyph="&#xEB51;" />
                        </AppBarButton.Icon>
                    </AppBarButton>
                    <Border Background="Transparent"
                            Padding="12"
                            PointerEntered="ColorBarBack_PointerEntered">
                        <Viewbox>
                            <SymbolIcon Symbol="Back" />
                        </Viewbox>
                    </Border>
                </StackPanel>
            </AppBarElementContainer>
            <muxc:CommandBarFlyout.SecondaryCommands>
                  <!-- Add some secondarycommand here-->
            </muxc:CommandBarFlyout.SecondaryCommands>
</muxc:CommandBarFlyout>
@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Apr 22, 2021
@StephenLPeters StephenLPeters added area-Commanding AppBar, UICommand, MVVM, etc area-UIDesign UI Design, styling team-Controls Issue for the Controls team labels Apr 22, 2021
@StephenLPeters StephenLPeters added this to the WinUI 2.6 milestone Apr 22, 2021
@StephenLPeters
Copy link
Contributor

@teaP FYI

@StephenLPeters StephenLPeters removed the needs-triage Issue needs to be triaged by the area owners label Apr 22, 2021
@ranjeshj
Copy link
Contributor

@StephenLPeters does this repro after your animation updates ?

@github-actions
Copy link

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Commanding AppBar, UICommand, MVVM, etc area-UIDesign UI Design, styling no-issue-activity team-Controls Issue for the Controls team
Projects
None yet
Development

No branches or pull requests

3 participants