Fix issue with selection being raised when selection did not change

[marcelwgn]

Description

Add checks for single selection to prevent raising event in case new selection is previous one.

Motivation and Context

Closes #1642

How Has This Been Tested?

Add API test

Screenshots (if appropriate):

[StephenLPeters]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[StephenLPeters]

[StephenLPeters]

@chingucoding these look like legitimate errors to me, could you take a look? :)

[marcelwgn]

Sure, will take a look later today. Thanks for the ping @StephenLPeters !

[marcelwgn]

My previous changes did not account for the fact that those methods also handle deselection. Should work now.

[ranjeshj]

void SelectionModel::SelectRangeFromAnchorImpl(int index, bool select)

This change is not accounting for no-ops during range selection, but perhaps we can add that support if/when the need arises and avoid the extra complexity.

---

Refers to: dev/Repeater/SelectionModel.cpp:690 in 6b1e4c7. [](commit_id = 6b1e4c7, deletion_comment = False)

[ranjeshj]

@ojhad @StephenLPeters do we have extra logic in NavigationView to avoid this bug that we could remove after this change ?

[marcelwgn]

@ojhad @StephenLPeters do we have extra logic in NavigationView to avoid this bug that we could remove after this change ?

The initial report originated during the switch of RadioButtons to ItemsRepeater. But it does not seem that for that, there was a fix deployed in the RadioButtons control: #1623 (comment)

If there was a fix for NavView or RadioButtons for this exact, I would be more than happy to remove that.

[ranjeshj]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[ojhad]

@ojhad @StephenLPeters do we have extra logic in NavigationView to avoid this bug that we could remove after this change ?

There is a check, but it shouldn't be removed, as it serves another purpose as well (when syncing selection between the NavigationView state and the selection model)