Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SelectionModel fires selection changed events when selection hasn't changed #1642

Closed
StephenLPeters opened this issue Nov 19, 2019 · 2 comments · Fixed by #2253
Closed

SelectionModel fires selection changed events when selection hasn't changed #1642

StephenLPeters opened this issue Nov 19, 2019 · 2 comments · Fixed by #2253
Assignees
@StephenLPeters
Labels
area-ItemsRepeater bug Something isn't working team-Controls Issue for the Controls team

Comments

@StephenLPeters
Copy link
Contributor

I think that this issue is exclusive to SingleSelect. Selection Model clears selection as the first action whenever you call select on it.
@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Nov 19, 2019
@StephenLPeters StephenLPeters mentioned this issue Nov 19, 2019
Merged
@jevansaks
Copy link
Member

@StephenLPeters from the description this seems simple enough. Can you take it?

@jevansaks jevansaks added area-ItemsRepeater bug Something isn't working team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Nov 20, 2019
@ranjeshj ranjeshj added help wanted Issue ideal for external contributors and removed help wanted Issue ideal for external contributors labels Feb 13, 2020
@marcelwgn
Copy link
Collaborator

@StephenLPeters Are you currently looking into this? 😅 If not, I would like to take this issue @ranjeshj .

@marcelwgn marcelwgn mentioned this issue Apr 8, 2020
Merged
@marcelwgn marcelwgn mentioned this issue Apr 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StephenLPeters StephenLPeters

Labels
area-ItemsRepeater bug Something isn't working team-Controls Issue for the Controls team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue with selection being raised when selection did not change marcelwgn/microsoft-ui-xaml
5 participants
@StephenLPeters @marcelwgn @jevansaks @ranjeshj @msft-github-bot