Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add longPathAware to shim manifest #2303

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

anmaxvl
Copy link
Contributor

@anmaxvl anmaxvl commented Oct 31, 2024

Depending on the version of Go used to build the shim binaries the process may or may not be long path aware, for example MS Go removed it microsoft/go@af3d04e.

Microsoft recommends adding long path support through manifest https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation?tabs=registry#enable-long-paths-in-windows-10-version-1607-and-later

@anmaxvl anmaxvl requested a review from a team as a code owner October 31, 2024 04:53
@anmaxvl anmaxvl force-pushed the manifest-long-path-support branch 2 times, most recently from 615f0af to edf9033 Compare October 31, 2024 09:17
Depending on the version of Go used to build the shim binaries
the process may or may not be long path aware, for example MS Go
removed it microsoft/go@af3d04e.

Microsoft recommends adding long path support through manifest
https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation?tabs=registry#enable-long-paths-in-windows-10-version-1607-and-later

Signed-off-by: Maksim An <[email protected]>
@anmaxvl anmaxvl force-pushed the manifest-long-path-support branch from edf9033 to 01194d5 Compare October 31, 2024 16:22
@anmaxvl
Copy link
Contributor Author

anmaxvl commented Oct 31, 2024

repushed, since license/cla was stuck.

@anmaxvl anmaxvl merged commit 1c29e9d into microsoft:main Oct 31, 2024
19 checks passed
@anmaxvl anmaxvl deleted the manifest-long-path-support branch October 31, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants