Skip to content

Commit

Permalink
add longPathAware to shim manifest
Browse files Browse the repository at this point in the history
Depending on the version of Go used to build the shim binaries
the process may or may not be long path aware, for example MS Go
removed it microsoft/go@af3d04e.

Microsoft recommends adding long path support through manifest
https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation?tabs=registry#enable-long-paths-in-windows-10-version-1607-and-later

Signed-off-by: Maksim An <[email protected]>
  • Loading branch information
anmaxvl committed Oct 31, 2024
1 parent 1b09526 commit edf9033
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,10 @@
<supportedOS Id="{8e0f7a12-bfb3-4fe8-b9a5-48fd50a15a9a}"/>
</application>
</compatibility>
<application xmlns="urn:schemas-microsoft-com:asm.v3">
<!-- Long Path Enablement -->
<windowsSettings xmlns:ws2="http://schemas.microsoft.com/SMI/2016/WindowsSettings">
<ws2:longPathAware>true</ws2:longPathAware>
</windowsSettings>
</application>
</assembly>
Binary file modified cmd/containerd-shim-runhcs-v1/resource_windows_386.syso
Binary file not shown.
Binary file modified cmd/containerd-shim-runhcs-v1/resource_windows_amd64.syso
Binary file not shown.
Binary file modified cmd/containerd-shim-runhcs-v1/resource_windows_arm.syso
Binary file not shown.
Binary file modified cmd/containerd-shim-runhcs-v1/resource_windows_arm64.syso
Binary file not shown.
6 changes: 3 additions & 3 deletions cmd/containerd-shim-runhcs-v1/versioninfo.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,15 @@
},
"StringFileInfo": {
"Comments": "",
"CompanyName": "",
"CompanyName": "Microsoft",
"FileDescription": "",
"FileVersion": "",
"InternalName": "",
"LegalCopyright": "",
"LegalTrademarks": "",
"OriginalFilename": "",
"OriginalFilename": "containerd-shim-runhcs-v1.exe",
"PrivateBuild": "",
"ProductName": "",
"ProductName": "runhcs shim",
"ProductVersion": "v1.0.0.0",
"SpecialBuild": ""
},
Expand Down

0 comments on commit edf9033

Please sign in to comment.