Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix create-package script #9491

Merged

Conversation

KevinTCoughlin
Copy link
Member

@KevinTCoughlin KevinTCoughlin commented Jun 18, 2019

Overview

Fixes create-package script.

Changes are:

Success output

~\Work\office-ui-fabric-react [keco/fix-create-package-script ↑4]> npm run create-package foo                           
> [email protected] create-package ~\office-ui-fabric-react
> node scripts/create-package.js "foo"

Creating .npmignore...
Creating .npmrc...
Creating CHANGELOG.json...
Creating CHANGELOG.md...
Creating LICENSE...
Creating README.md...
Creating index.html...
Creating just.config.js...
Creating jest.config.js...
Creating jsconfig.json...
Creating package.json...
Creating prettier.config.js...
Creating tsconfig.json...
Creating tslint.json...
Creating webpack.config.js...
Creating webpack.serve.config.js...
Creating config\tests.js...
Creating config\pre-copy.json...
Creating src\common\tests.js...
Creating src\index.ts...
Creating src\version.ts...
Creating src\demo\AppDefinition.tsx...
Creating src\demo\GettingStartedPage.tsx...
Creating src\demo\index.tsx...
New package foo successfully created.
Running "npm generate" (to bypass this step, use --no-generate arg)

> [email protected] generate ~\office-ui-fabric-react
> npm run rush-update


> [email protected] rush-update ~\office-ui-fabric-react
> node common/scripts/install-run-rush.js update

The rush.json configuration requests Rush version 5.6.0

Invoking "rush update"
----------------------



Rush Multi-Project Build Tool 5.6.0 - https://rushjs.io


Starting "rush update"

Warning: A phantom "node_modules" folder was found. This defeats Rush's protection against NPM phantom dependencies and
may cause confusing build errors. It is recommended to delete this folder:
"~\office-ui-fabric-react\node_modules"


Found files in the "common/git-hooks" folder.
Successfully installed these Git hook scripts: pre-commit

Trying to acquire lock for pnpm-2.19.2
Acquired lock for pnpm-2.19.2
Found pnpm version 2.19.2 in C:\Users\keco\.rush\node-v10.15.0\pnpm-2.19.2

Symlinking "~\office-ui-fabric-react\common\temp\pnpm-local"
  --> "C:\Users\keco\.rush\node-v10.15.0\pnpm-2.19.2"

Updating temp projects in ~\office-ui-fabric-react\common\temp\projects
Copying ~\office-ui-fabric-react\common\config\rush\.npmrc --> ~\office-ui-fabric-react\common\temp\.npmrc
Updating ~\office-ui-fabric-react\common\temp\pnpmfile.js
Updating ~\office-ui-fabric-react\common\temp\projects\foo.tgz
Finished creating temporary modules (0.54 seconds)

The shrinkwrap file is missing the following dependencies:
  "@microsoft/load-themed-styles" (^1.7.13) required by "@uifabric/foo"
  "@types/enzyme" (3.1.13) required by "@uifabric/foo"
  "@types/enzyme-adapter-react-16" (1.0.3) required by "@uifabric/foo"
  "@types/es6-promise" (0.0.32) required by "@uifabric/foo"
  "@types/jest" (23.0.0) required by "@uifabric/foo"
  "@types/react" (16.8.11) required by "@uifabric/foo"
  "@types/react-dom" (16.8.4) required by "@uifabric/foo"
  "@types/react-test-renderer" (^16.0.0) required by "@uifabric/foo"
  "@types/webpack-env" (1.13.9) required by "@uifabric/foo"
  "enzyme" (~3.9.0) required by "@uifabric/foo"
  "enzyme-adapter-react-16" (^1.2.0) required by "@uifabric/foo"
  "es6-weak-map" (^2.0.2) required by "@uifabric/foo"
  "react" (16.8.6) required by "@uifabric/foo"
  "react-dom" (16.8.6) required by "@uifabric/foo"
  "react-test-renderer" (^16.3.0) required by "@uifabric/foo"
  "tslib" (^1.7.1) required by "@uifabric/foo"


Checking node_modules in ~\office-ui-fabric-react\common\temp

Deleting: ~\office-ui-fabric-react\common\temp\rush-link.json

Running "pnpm install" in ~\office-ui-fabric-react\common\temp

Using hooks from: ~\office-ui-fabric-react\common\temp\pnpmfile.js
readPackage hook is declared. Manifests of dependencies might get overridden
 WARN  deprecated [email protected]: 'github' has been renamed to '@octokit/rest' (https://git.io/vNB11)
Already up-to-date
Resolving: total 1900, reused 1849, downloaded 41, done
 WARN  Cannot link bin "jest" of "jest-cli" to "~\office-ui-fabric-react\common\temp\node_modules\.bin". A package called "jest" already has its bin linked.
Updating ~\office-ui-fabric-react\common\config\rush\shrinkwrap.yaml

Linking projects together...

LINKING: @uifabric/api-docs
Purging ~\office-ui-fabric-react\packages\api-docs\node_modules

LINKING: @uifabric/azure-themes
Purging ~\office-ui-fabric-react\packages\azure-themes\node_modules

LINKING: @uifabric/build
Purging ~\office-ui-fabric-react\scripts\node_modules

LINKING: @uifabric/charting
Purging ~\office-ui-fabric-react\packages\charting\node_modules

LINKING: @uifabric/codepen-loader
Purging ~\office-ui-fabric-react\packages\codepen-loader\node_modules

LINKING: @uifabric/date-time
Purging ~\office-ui-fabric-react\packages\date-time\node_modules

LINKING: @uifabric/example-app-base
Purging ~\office-ui-fabric-react\packages\example-app-base\node_modules

LINKING: @uifabric/experiments
Purging ~\office-ui-fabric-react\packages\experiments\node_modules

LINKING: @uifabric/fabric-website
Purging ~\office-ui-fabric-react\apps\fabric-website\node_modules

LINKING: @uifabric/fabric-website-resources
Purging ~\office-ui-fabric-react\apps\fabric-website-resources\node_modules

LINKING: @uifabric/file-type-icons
Purging ~\office-ui-fabric-react\packages\file-type-icons\node_modules

LINKING: @uifabric/fluent-theme
Purging ~\office-ui-fabric-react\packages\fluent-theme\node_modules

LINKING: @uifabric/foo
Purging ~\office-ui-fabric-react\packages\foo\node_modules

LINKING: @uifabric/foundation
Purging ~\office-ui-fabric-react\packages\foundation\node_modules

LINKING: @uifabric/foundation-scenarios
Purging ~\office-ui-fabric-react\packages\foundation-scenarios\node_modules

LINKING: @uifabric/icons
Purging ~\office-ui-fabric-react\packages\icons\node_modules

LINKING: @uifabric/jest-serializer-merge-styles
Purging ~\office-ui-fabric-react\packages\jest-serializer-merge-styles\node_modules

LINKING: @uifabric/lists
Purging ~\office-ui-fabric-react\packages\lists\node_modules

LINKING: @uifabric/merge-styles
Purging ~\office-ui-fabric-react\packages\merge-styles\node_modules

LINKING: @uifabric/migration
Purging ~\office-ui-fabric-react\packages\migration\node_modules

LINKING: @uifabric/pr-deploy-site
Purging ~\office-ui-fabric-react\apps\pr-deploy-site\node_modules

LINKING: @uifabric/prettier-rules
Purging ~\office-ui-fabric-react\packages\prettier-rules\node_modules

LINKING: @uifabric/react-cards
Purging ~\office-ui-fabric-react\packages\react-cards\node_modules

LINKING: @uifabric/set-version
Purging ~\office-ui-fabric-react\packages\set-version\node_modules

LINKING: @uifabric/styling
Purging ~\office-ui-fabric-react\packages\styling\node_modules

LINKING: @uifabric/test-utilities
Purging ~\office-ui-fabric-react\packages\test-utilities\node_modules

LINKING: @uifabric/theme-samples
Purging ~\office-ui-fabric-react\packages\theme-samples\node_modules

LINKING: @uifabric/tslint-rules
Purging ~\office-ui-fabric-react\packages\tslint-rules\node_modules

LINKING: @uifabric/utilities
Purging ~\office-ui-fabric-react\packages\utilities\node_modules

LINKING: @uifabric/variants
Purging ~\office-ui-fabric-react\packages\variants\node_modules

LINKING: @uifabric/webpack-utils
Purging ~\office-ui-fabric-react\packages\webpack-utils\node_modules

LINKING: a11y-tests
Purging ~\office-ui-fabric-react\apps\a11y-tests\node_modules
createFolderWithRetry() stalled for 3.77 seconds

LINKING: dom-tests
Purging ~\office-ui-fabric-react\apps\dom-tests\node_modules

LINKING: office-ui-fabric-react
Purging ~\office-ui-fabric-react\packages\office-ui-fabric-react\node_modules

LINKING: perf-test
Purging ~\office-ui-fabric-react\apps\perf-test\node_modules

LINKING: server-rendered-app
Purging ~\office-ui-fabric-react\apps\server-rendered-app\node_modules

LINKING: ssr-tests
Purging ~\office-ui-fabric-react\apps\ssr-tests\node_modules

LINKING: test-bundles
Purging ~\office-ui-fabric-react\apps\test-bundles\node_modules

LINKING: theming-designer
Purging ~\office-ui-fabric-react\apps\theming-designer\node_modules

LINKING: todo-app
Purging ~\office-ui-fabric-react\apps\todo-app\node_modules

LINKING: vr-tests
Purging ~\office-ui-fabric-react\apps\vr-tests\node_modules
Writing "~\office-ui-fabric-react\common\temp\rush-link.json"

Linking finished successfully. (9.75 seconds)

Next you should probably run "rush build" or "rush rebuild"

Rush update finished successfully. (1 minute 54.7 seconds)
Microsoft Reviewers: Open in CodeFlow

@msft-github-bot
Copy link
Contributor

Hello @cliffkoh!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 7 hours 49 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msft-github-bot) and give me an instruction to get started! Learn more here.

@cliffkoh
Copy link
Contributor

@msft-github-bot please make sure @ecraig12345 or @kenotron approves.

@msft-github-bot
Copy link
Contributor

Hello @cliffkoh!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@size-auditor
Copy link

size-auditor bot commented Jun 18, 2019

Size Auditor did not detect a change in bundle size for any component!

@msft-github-bot
Copy link
Contributor

msft-github-bot commented Jun 18, 2019

Component perf results:

Scenario Target branch avg total (ms) PR avg total (ms) Target branch avg per item (ms) PR avg per item (ms) Is significant change Is regression
ScenarioDefaultButton 44.693 43.771 0.447 0.438 false false

Copy link
Member

@ecraig12345 ecraig12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@KevinTCoughlin KevinTCoughlin merged commit b1c5ad4 into microsoft:master Jun 18, 2019
@KevinTCoughlin KevinTCoughlin deleted the keco/fix-create-package-script branch June 18, 2019 18:20
Markionium added a commit to Markionium/office-ui-fabric-react that referenced this pull request Jun 19, 2019
* master: (46 commits)
  Enable conditional rendering of page sections depending on query present in the url to enable iframe rendering of examples on docs.microsoft OUFR portal (microsoft#9438)
  Applying package updates.
  Make more examples exportable to codepen (microsoft#9468)
  Fix create-package script (microsoft#9491)
  Card: Making elevation themable by using the effects from theme instead of directly referencing Depths (microsoft#9472)
  Revert "Tooltip: improve perf by preventing all render until after de… (microsoft#9495)
  a11y-tests: Run a11y tests on all component examples (microsoft#9479)
  Website (mobile): Add source code links, remove generic library link (microsoft#9487)
  Facepile - Adding OnRenderPersona and OnRenderPersonaCoin as optional… (microsoft#9480)
  Applying package updates.
  Accessibility improvement for DetailsList while placeholder data is being displayed (microsoft#9484)
  Button: Getting anchor native props if href prop is specified (microsoft#9456)
  Fabric website: add documentation entry points. (microsoft#9477)
  Website: Add overview and control request sections to mobile pages. (microsoft#9483)
  Fixing some styling bugs in theme designer: theme slots pivot was not centered & Main part of the page with the 3 stacks had a margin when it was unnecessary. Also cleaned up the code by creating a separate component for ThemeSlots that does the pivoting. (microsoft#9458)
  Only run KeytipManager update when relevant keytip props have changed (microsoft#9414)
  Theme colors page (microsoft#9369)
  Prevent Callout from being dismissed after mouse pressed inside but released outside (microsoft#9415)
  Add data viz separator for HorizontalBarChart (microsoft#9482)
  Applying package updates.
  ...
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants