-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix create-package script #9491
Fix create-package script #9491
Conversation
Hello @cliffkoh! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 7 hours 49 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
@msft-github-bot please make sure @ecraig12345 or @kenotron approves. |
Hello @cliffkoh! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
Size Auditor did not detect a change in bundle size for any component! |
Component perf results:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
* master: (46 commits) Enable conditional rendering of page sections depending on query present in the url to enable iframe rendering of examples on docs.microsoft OUFR portal (microsoft#9438) Applying package updates. Make more examples exportable to codepen (microsoft#9468) Fix create-package script (microsoft#9491) Card: Making elevation themable by using the effects from theme instead of directly referencing Depths (microsoft#9472) Revert "Tooltip: improve perf by preventing all render until after de… (microsoft#9495) a11y-tests: Run a11y tests on all component examples (microsoft#9479) Website (mobile): Add source code links, remove generic library link (microsoft#9487) Facepile - Adding OnRenderPersona and OnRenderPersonaCoin as optional… (microsoft#9480) Applying package updates. Accessibility improvement for DetailsList while placeholder data is being displayed (microsoft#9484) Button: Getting anchor native props if href prop is specified (microsoft#9456) Fabric website: add documentation entry points. (microsoft#9477) Website: Add overview and control request sections to mobile pages. (microsoft#9483) Fixing some styling bugs in theme designer: theme slots pivot was not centered & Main part of the page with the 3 stacks had a margin when it was unnecessary. Also cleaned up the code by creating a separate component for ThemeSlots that does the pivoting. (microsoft#9458) Only run KeytipManager update when relevant keytip props have changed (microsoft#9414) Theme colors page (microsoft#9369) Prevent Callout from being dismissed after mouse pressed inside but released outside (microsoft#9415) Add data viz separator for HorizontalBarChart (microsoft#9482) Applying package updates. ...
Overview
Fixes
create-package
script.Changes are:
package.json
template (0535118)rush install
andrush update
(8e34c92)@uifabric/build
topackage.json
template (b002236, 8c37aa0)Success output
Microsoft Reviewers: Open in CodeFlow