Theme Designer: Fixing some styling bugs in ThemeSlots, Header, and Main. #9458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… centered & Main part of the page with the 3 stacks had a margin when it was unnecessary. Also cleaned up the code by creating a separate component for ThemeSlots that does the pivoting.
|
Component perf results:
|
|
Size Auditor did not detect a change in bundle size for any component! |
jdhuntington
approved these changes
Jun 17, 2019
Markionium
added a commit
to Markionium/office-ui-fabric-react
that referenced
this pull request
Jun 19, 2019
* master: (46 commits) Enable conditional rendering of page sections depending on query present in the url to enable iframe rendering of examples on docs.microsoft OUFR portal (microsoft#9438) Applying package updates. Make more examples exportable to codepen (microsoft#9468) Fix create-package script (microsoft#9491) Card: Making elevation themable by using the effects from theme instead of directly referencing Depths (microsoft#9472) Revert "Tooltip: improve perf by preventing all render until after de… (microsoft#9495) a11y-tests: Run a11y tests on all component examples (microsoft#9479) Website (mobile): Add source code links, remove generic library link (microsoft#9487) Facepile - Adding OnRenderPersona and OnRenderPersonaCoin as optional… (microsoft#9480) Applying package updates. Accessibility improvement for DetailsList while placeholder data is being displayed (microsoft#9484) Button: Getting anchor native props if href prop is specified (microsoft#9456) Fabric website: add documentation entry points. (microsoft#9477) Website: Add overview and control request sections to mobile pages. (microsoft#9483) Fixing some styling bugs in theme designer: theme slots pivot was not centered & Main part of the page with the 3 stacks had a margin when it was unnecessary. Also cleaned up the code by creating a separate component for ThemeSlots that does the pivoting. (microsoft#9458) Only run KeytipManager update when relevant keytip props have changed (microsoft#9414) Theme colors page (microsoft#9369) Prevent Callout from being dismissed after mouse pressed inside but released outside (microsoft#9415) Add data viz separator for HorizontalBarChart (microsoft#9482) Applying package updates. ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Fixing some styling bugs in theme designer: theme slots pivot was not centered & Main part of the page with the 3 stacks had a margin when it was unnecessary. Also cleaned up the code by creating a separate component for ThemeSlots that does the pivoting.
Focus areas to test
(optional)
Microsoft Reviewers: Open in CodeFlow