Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update create-component template to use ForwardRefComponent #20118

Merged
merged 1 commit into from
Oct 6, 2021
Merged

Update create-component template to use ForwardRefComponent #20118

merged 1 commit into from
Oct 6, 2021

Conversation

ecraig12345
Copy link
Member

Update the create-component template to use ForwardRefComponent (from #19923) as the type of newly-created components.

@ecraig12345 ecraig12345 requested a review from bsunderhus October 6, 2021 07:41
@ecraig12345 ecraig12345 requested a review from a team as a code owner October 6, 2021 07:41
@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 6, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6ac06fd:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Oct 6, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 57d7a963289d7a8639b2c0c58065441599fdde1b (build)

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-accordion
Accordion (including children components)		 57.532 kB
18.112 kB
react-avatar
Avatar		 54.953 kB
15.667 kB
react-badge
Badge		 23.182 kB
6.986 kB
react-badge
CounterBadge		 25.642 kB
7.682 kB
react-badge
PresenseBadge		 237 B
177 B
react-button
Button		 25.501 kB
7.738 kB
react-button
CompoundButton		 30.758 kB
8.689 kB
react-button
MenuButton		 27.526 kB
8.413 kB
react-button
SplitButton		 33.637 kB
9.597 kB
react-button
ToggleButton		 34.727 kB
8.39 kB
react-card
Card - All		 13.471 kB
5.068 kB
react-card
Card		 9.317 kB
3.925 kB
react-card
CardFooter		 8.468 kB
3.557 kB
react-card
CardHeader		 9.695 kB
3.99 kB
react-card
CardPreview		 8.783 kB
3.741 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 169.173 kB
48.002 kB
react-components
react-components: FluentProvider & webLightTheme		 32.188 kB
10.658 kB
react-divider
Divider		 15.342 kB
5.585 kB
react-image
Image		 9.771 kB
3.975 kB
react-input
Input		 31.319 kB
11.305 kB
react-label
Label		 8.952 kB
3.708 kB
react-link
Link		 11.646 kB
4.699 kB
react-make-styles
makeStaticStyles (runtime)		 7.59 kB
3.321 kB
react-make-styles
makeStyles + mergeClasses (runtime)		 22.175 kB
8.366 kB
react-make-styles
makeStyles + mergeClasses (build time)		 2.558 kB
1.204 kB
react-menu
Menu (including children components)		 105.789 kB
32.202 kB
react-menu
Menu (including selectable components)		 108.065 kB
32.575 kB
react-popover
Popover		 101.153 kB
30.37 kB
react-portal
Portal		 6.725 kB
2.237 kB
react-positioning
usePopper		 23.145 kB
7.942 kB
react-provider
FluentProvider		 15.147 kB
5.573 kB
react-slider
RangedSlider		 41.41 kB
11.97 kB
react-slider
Slider		 34.788 kB
10.855 kB
react-switch
Switch		 26.606 kB
8.557 kB
react-text
Text - Default		 11.338 kB
4.418 kB
react-text
Text - Wrappers		 14.407 kB
4.724 kB
react-theme
Teams: all themes		 25.712 kB
6.17 kB
react-theme
Teams: Light theme		 17.215 kB
5.116 kB
react-tooltip
Tooltip		 45.543 kB
15.541 kB
react-utilities
SSRProvider		 213 B
170 B
🤖 This report was generated against 57d7a963289d7a8639b2c0c58065441599fdde1b

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1014 1062 5000
BaseButton mount 988 1015 5000
Breadcrumb mount 2791 2770 1000
ButtonNext mount 563 557 5000
Checkbox mount 1684 1753 5000
CheckboxBase mount 1474 1436 5000
ChoiceGroup mount 5215 5182 5000
ComboBox mount 1015 1010 1000
CommandBar mount 10523 10705 1000
ContextualMenu mount 6734 6591 1000
DefaultButton mount 1216 1212 5000
DetailsRow mount 4053 4032 5000
DetailsRowFast mount 4101 4140 5000
DetailsRowNoStyles mount 3873 3857 5000
Dialog mount 2671 2633 1000
DocumentCardTitle mount 181 183 1000
Dropdown mount 3559 3616 5000
FluentProviderNext mount 3328 3476 5000
FluentProviderWithTheme mount 231 192 10
FluentProviderWithTheme virtual-rerender 100 114 10
FluentProviderWithTheme virtual-rerender-with-unmount 245 234 10
FocusTrapZone mount 1981 1972 5000
FocusZone mount 1903 1923 5000
IconButton mount 1968 1945 5000
Label mount 376 355 5000
Layer mount 3375 3279 5000
Link mount 506 563 5000
MakeStyles mount 1925 1883 50000
MenuButton mount 1623 1647 5000
MessageBar mount 2193 2177 5000
Nav mount 3674 3622 1000
OverflowSet mount 1202 1219 5000
Panel mount 2531 2501 1000
Persona mount 959 958 1000
Pivot mount 1529 1583 1000
PrimaryButton mount 1443 1425 5000
Rating mount 8564 8671 5000
SearchBox mount 1483 1467 5000
Shimmer mount 2831 2832 5000
Slider mount 2112 2098 5000
SpinButton mount 5503 5433 5000
Spinner mount 457 476 5000
SplitButton mount 3409 3476 5000
Stack mount 564 594 5000
StackWithIntrinsicChildren mount 2006 1922 5000
StackWithTextChildren mount 5225 5359 5000
SwatchColorPicker mount 11326 11537 5000
Tabs mount 1540 1533 1000
TagPicker mount 2813 2933 5000
TeachingBubble mount 13612 13731 5000
Text mount 477 465 5000
TextField mount 1571 1575 5000
ThemeProvider mount 1256 1296 5000
ThemeProvider virtual-rerender 668 652 5000
ThemeProvider virtual-rerender-with-unmount 2086 2154 5000
Toggle mount 875 946 5000
buttonNative mount 164 135 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
FlexMinimalPerf.default 337 301 1.12:1
ToolbarMinimalPerf.default 1092 1004 1.09:1
DividerMinimalPerf.default 426 395 1.08:1
DropdownManyItemsPerf.default 798 739 1.08:1
LayoutMinimalPerf.default 414 382 1.08:1
TextAreaMinimalPerf.default 633 584 1.08:1
TableMinimalPerf.default 480 450 1.07:1
CardMinimalPerf.default 651 614 1.06:1
RadioGroupMinimalPerf.default 515 488 1.06:1
SkeletonMinimalPerf.default 407 384 1.06:1
TextMinimalPerf.default 400 378 1.06:1
VideoMinimalPerf.default 706 665 1.06:1
AlertMinimalPerf.default 327 312 1.05:1
BoxMinimalPerf.default 412 394 1.05:1
GridMinimalPerf.default 397 378 1.05:1
ChatWithPopoverPerf.default 435 418 1.04:1
HeaderMinimalPerf.default 432 417 1.04:1
ItemLayoutMinimalPerf.default 1389 1332 1.04:1
ListWith60ListItems.default 719 694 1.04:1
MenuButtonMinimalPerf.default 1858 1781 1.04:1
IconMinimalPerf.default 692 663 1.04:1
CustomToolbarPrototype.default 4542 4348 1.04:1
ChatDuplicateMessagesPerf.default 330 321 1.03:1
ChatMinimalPerf.default 728 704 1.03:1
DatepickerMinimalPerf.default 6026 5828 1.03:1
ListNestedPerf.default 629 608 1.03:1
MenuMinimalPerf.default 937 914 1.03:1
PortalMinimalPerf.default 192 186 1.03:1
SegmentMinimalPerf.default 402 390 1.03:1
AccordionMinimalPerf.default 184 181 1.02:1
EmbedMinimalPerf.default 4705 4610 1.02:1
ListMinimalPerf.default 562 551 1.02:1
RosterPerf.default 1369 1343 1.02:1
RefMinimalPerf.default 261 255 1.02:1
AnimationMinimalPerf.default 462 457 1.01:1
AttachmentSlotsPerf.default 1260 1247 1.01:1
CarouselMinimalPerf.default 522 518 1.01:1
TooltipMinimalPerf.default 1161 1154 1.01:1
TreeWith60ListItems.default 209 207 1.01:1
ButtonSlotsPerf.default 626 625 1:1
DropdownMinimalPerf.default 3340 3351 1:1
ImageMinimalPerf.default 441 443 1:1
ProviderMergeThemesPerf.default 1742 1738 1:1
ProviderMinimalPerf.default 1193 1197 1:1
ReactionMinimalPerf.default 421 421 1:1
SplitButtonMinimalPerf.default 4726 4717 1:1
TreeMinimalPerf.default 917 915 1:1
AttachmentMinimalPerf.default 200 203 0.99:1
AvatarMinimalPerf.default 237 240 0.99:1
ButtonOverridesMissPerf.default 1997 2011 0.99:1
CheckboxMinimalPerf.default 2885 2915 0.99:1
FormMinimalPerf.default 468 475 0.99:1
InputMinimalPerf.default 1383 1398 0.99:1
LoaderMinimalPerf.default 738 742 0.99:1
StatusMinimalPerf.default 756 761 0.99:1
TableManyItemsPerf.default 2091 2121 0.99:1
DialogMinimalPerf.default 826 843 0.98:1
HeaderSlotsPerf.default 854 868 0.98:1
PopupMinimalPerf.default 631 641 0.98:1
SliderMinimalPerf.default 1826 1871 0.98:1
ButtonMinimalPerf.default 201 207 0.97:1
LabelMinimalPerf.default 412 428 0.96:1
ListCommonPerf.default 709 737 0.96:1

@ecraig12345 ecraig12345 merged commit 8df3ce7 into microsoft:master Oct 6, 2021
@ecraig12345 ecraig12345 deleted the forwardref-template branch October 6, 2021 08:54
mlp73 pushed a commit to mlp73/fluentui that referenced this pull request Jan 17, 2022
@ecraig12345
Update create-package template to use ForwardRefComponent (microsoft#…
d4bca65 
…20118)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ling1726 ling1726 ling1726 approved these changes

@bsunderhus bsunderhus Awaiting requested review from bsunderhus

Assignees

@bsunderhus bsunderhus

Labels
Area: Build System
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ecraig12345 @fabricteam @ling1726 @bsunderhus @msft-fluent-ui-bot