Migrate Checkbox to functional component #12614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asset size changes
Baseline commit: 1c286ff567d6dc005fe3d096285f05d87786228e (build) |
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
2 tasks
xugao
reviewed
Apr 23, 2020
MLoughry
requested review from
dvdzkwsk,
jurokapsiar,
layershifter,
levithomason,
miroslavstastny,
mnajdova and
pompomon
as code owners
dzearing
reviewed
Apr 28, 2020
dzearing
approved these changes
Apr 28, 2020
xugao
reviewed
Apr 29, 2020
xugao
approved these changes
Apr 29, 2020
xugao
added
Component: Checkbox
Fluent UI v8
and removed
PR: Possible Perf Regression 🐌
labels
|
@MLoughry - anything blocking you from merging? |
|
@xugao I have no reason not to merge this. However,
|
|
@MLoughry - got it. i will merge it once ready |
|
@MLoughry Looks like you have write permissions but not admin. (we may have gotten a bit too much in the habit of relying on admin perms to merge in some cases lately) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
This change migrates the Checkbox control to a function component in the
react-nextpackage.Ping: @dzearing @ecraig12345 @micahgodbolt
Microsoft Reviewers: Open in CodeFlow