Add new hooks used in migrating Fabric components to functional components #12629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 7fc234896718e61af6113ddab56f3d6d7ee20154 (build) |
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
|
Not sure why the Screener baseline is missing an image |
dzearing
reviewed
Apr 10, 2020
dzearing
reviewed
Apr 10, 2020
dzearing
requested changes
Apr 10, 2020
|
Ping. @dzearing, is this ok to merge? |
ecraig12345
reviewed
Apr 16, 2020
ecraig12345
reviewed
Apr 16, 2020
ecraig12345
reviewed
Apr 16, 2020
ecraig12345
reviewed
Apr 16, 2020
Co-Authored-By: Elizabeth Craig <[email protected]>
ecraig12345
reviewed
Apr 16, 2020
ecraig12345
reviewed
Apr 16, 2020
ecraig12345
reviewed
Apr 16, 2020
Co-Authored-By: Elizabeth Craig <[email protected]>
Co-Authored-By: Elizabeth Craig <[email protected]>
dzearing
approved these changes
Apr 21, 2020
dzearing
approved these changes
Apr 21, 2020
|
Per our Teams discussion, preventing the call to |
|
🎉 Handy links: |
DuanShaolong
pushed a commit
to DuanShaolong/fluentui
that referenced
this pull request
Apr 27, 2020
…nents (microsoft#12629) * Add new hooks used in migrating Fabric components to functional components * Change files * Cherry pick revision from MLoughry:functional/checkbox * Fix lint error * Address comments from dzearing * Fix launch.json for debugging tests * Use common onChange call signature * Fix useControllableValue types in case with no onChange handler * Export ChangeCallback type * Persist the controlled vs uncontrolled state * Update packages/react-hooks/src/useMergedRefs.ts Co-Authored-By: Elizabeth Craig <[email protected]> * Update README * Allow for undefined events in the onChange callback * Fix error in isControlled value * Delete test for deprecated behavior * Update packages/react-hooks/README.md Co-Authored-By: Elizabeth Craig <[email protected]> * Update packages/react-hooks/README.md Co-Authored-By: Elizabeth Craig <[email protected]> Co-authored-by: Elizabeth Craig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
The hook changes/additions are plucked from my branches migrating a couple components to functional components (https://github.com/MLoughry/office-ui-fabric-react/tree/functional/fabric, https://github.com/MLoughry/office-ui-fabric-react/tree/functional/checkbox). While those changes may have to wait for a new major version, these changes are non-breaking and will allow me to use these hooks across further migrations while we figure out how/when to merge the migrations.
Focus areas to test
(optional)
Microsoft Reviewers: Open in CodeFlow