Implementation of CGPattern via runtime base #2374

msft-Jeyaram · 2017-03-30T02:59:56Z

rajsesh · 2017-03-30T18:33:42Z

Frameworks/UIKit/UIColor.mm

@@ -518,12 +518,12 @@ - (UIColor*)initWithPatternImage:(UIImage*)image {
 callbacks.releaseInfo = 0;
 callbacks.drawPattern = __UIColorPatternFill;

-_pattern = (id) CGPatternCreateColorspace(self, bounds, m, bounds.size.width, bounds.size.height, 0, NO, &callbacks, pImg->_has32BitAlpha ? _ColorABGR : _ColorBGR);
+_pattern = _CGPatternCreateColorspace(self, bounds, m, bounds.size.width, bounds.size.height, 0, NO, &callbacks, pImg->_has32BitAlpha ? _ColorABGR : _ColorBGR);


Lets remove the code in #if 0. #Resolved

rajsesh · 2017-03-30T18:40:57Z

Frameworks/UIKit/UIColor.mm

@@ -224,7 +224,7 @@ @implementation UIColor {
 @public
    enum BrushType _type;
    UIImage* _image;


nit: while we are at this, could this be StrongId<>? #Resolved

rajsesh · 2017-03-30T18:42:14Z

Frameworks/CoreGraphics/CGPattern.mm

- (void)dealloc {
-    if (generatedImage) {
-        CGImageRelease(generatedImage);
+    inline CGAffineTransform TransformMatrix() const {


Nit: The name sounds like a verb. Adding a Get will clarify the intent. #Resolved

rajsesh · 2017-03-30T18:42:35Z

Frameworks/CoreGraphics/CGPattern.mm

-
-    if (generatedImage) {
-        CGImageRelease(generatedImage);
+    inline CGRect Bounds() const {


nit: could return const ref. #Resolved

rajsesh · 2017-03-30T18:42:50Z

Frameworks/CoreGraphics/CGPattern.mm

-    } else {
-        bitmapInfo = kCGImageAlphaNone;
-        colorSpace = CGColorSpaceCreateDeviceGray();
+    inline CGAffineTransform PatternTransform() {


nit: GetPatternTransform() const #Resolved

DHowett-MSFT · 2017-03-30T19:34:00Z

Frameworks/CoreGraphics/CGPattern.mm

-
-    return generatedImage;
-}
+    inline CGPatternCallbacks Callbacks() const {


This is unused. Either use it or delete IssuePatternCallback #Resolved

DHowett-MSFT · 2017-03-30T19:35:10Z

Frameworks/include/CGPatternInternal.h

@@ -58,5 +42,14 @@ CGRect _CGPatternGetFinalPatternSize(CGPatternRef pattern);
 */
 bool _CGPatternIsColored(CGPatternRef pattern);

+COREGRAPHICS_EXPORT CGPatternRef _CGPatternCreateColorspace(void* info,


this doesn't actually take or create a color space? #Resolved

no longer needed.

In reply to: 109017103 [](ancestors = 109017103)

DHowett-MSFT · 2017-03-30T19:35:32Z

build/CoreGraphics/dll/CoreGraphics.def

@@ -450,6 +450,7 @@ LIBRARY CoreGraphics

        ; private exports below
        _CGPatternCreateFromImage
+        _CGPatternCreateColorspace


this is only used internally, why is it exported? #Resolved

actually it was in UIColor but now that's being removed. taking it out.

In reply to: 109017192 [](ancestors = 109017192)

msft-Jeyaram · 2017-03-30T20:20:25Z

@DHowett-MSFT @rajsesh-msft updated :)

MSFTFox · 2017-03-30T21:21:49Z

Frameworks/CoreGraphics/CGPattern.mm

-
-    return ret;
-}
+static const wchar_t* TAG = L"CGPattern";


Seems unused with LoggingNative? #Resolved

MSFTFox · 2017-03-30T21:23:43Z

Frameworks/CoreGraphics/CGPattern.mm

+    void* _info;
+    CGRect _bounds;
+    CGAffineTransform _transformMatrix;
+    CGFloat _xStep;


xstep and ystep could be CGSize for simplicity. #WontFix

it's much more implicit this way.

In reply to: 109041128 [](ancestors = 109041128)

Also removed dependency on foundation as we removed usage and removal of NSObjects.

…fines it as void *, it should be struct __CGPattern*

…ns and code

…o better manage it's life time

msft-Jeyaram · 2017-03-31T17:40:01Z

Awaiting ARM test verification.

msft-Jeyaram requested review from rajsesh and MSFTFox March 30, 2017 02:59

msftclas added the cla-not-required label Mar 30, 2017

msft-Jeyaram force-pushed the CGPattern_CPPBased_29_3 branch from d968617 to 98f2cc6 Compare March 30, 2017 03:05

rajsesh suggested changes Mar 30, 2017

View reviewed changes

DHowett-MSFT suggested changes Mar 30, 2017

View reviewed changes

MSFTFox approved these changes Mar 30, 2017

View reviewed changes

DHowett-MSFT approved these changes Mar 30, 2017

View reviewed changes

msft-Jeyaram added 4 commits March 31, 2017 08:42

Implementation of CGPattern via run CF Runtime base.

6a61792

Also removed dependency on foundation as we removed usage and removal of NSObjects.

Define the proper typedef for CGPatternRef. The current definition de…

3a81540

…fines it as void *, it should be struct __CGPattern*

Add Proper usage of pattern to UIColor and remove unnecessary functio…

3387eea

…ns and code

UIImage in UIColor, which is of a pattern, should be using StrongId t…

fa7f2ec

…o better manage it's life time

msft-Jeyaram force-pushed the CGPattern_CPPBased_29_3 branch from e0f2870 to fa7f2ec Compare March 31, 2017 16:16

msft-Jeyaram merged commit 451877b into microsoft:develop Mar 31, 2017

msft-Jeyaram mentioned this pull request Apr 27, 2017

Break CoreGraphics and CoreText's dependencies on Foundation + UIKit #2026

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implementation of CGPattern via runtime base #2374

Implementation of CGPattern via runtime base #2374

msft-Jeyaram commented Mar 30, 2017

rajsesh Mar 30, 2017 •

edited by msft-Jeyaram

Loading

rajsesh Mar 30, 2017 •

edited by msft-Jeyaram

Loading

rajsesh Mar 30, 2017 •

edited by msft-Jeyaram

Loading

rajsesh Mar 30, 2017 •

edited by msft-Jeyaram

Loading

rajsesh Mar 30, 2017 •

edited by msft-Jeyaram

Loading

DHowett-MSFT Mar 30, 2017 •

edited by msft-Jeyaram

Loading

DHowett-MSFT Mar 30, 2017 •

edited by msft-Jeyaram

Loading

msft-Jeyaram Mar 30, 2017

DHowett-MSFT Mar 30, 2017 •

edited by msft-Jeyaram

Loading

msft-Jeyaram Mar 30, 2017

msft-Jeyaram commented Mar 30, 2017

MSFTFox Mar 30, 2017 •

edited by msft-Jeyaram

Loading

MSFTFox Mar 30, 2017 •

edited by msft-Jeyaram

Loading

msft-Jeyaram Mar 30, 2017

msft-Jeyaram commented Mar 31, 2017

Implementation of CGPattern via runtime base #2374

Implementation of CGPattern via runtime base #2374

Conversation

msft-Jeyaram commented Mar 30, 2017

rajsesh Mar 30, 2017 • edited by msft-Jeyaram Loading

Choose a reason for hiding this comment

rajsesh Mar 30, 2017 • edited by msft-Jeyaram Loading

Choose a reason for hiding this comment

rajsesh Mar 30, 2017 • edited by msft-Jeyaram Loading

Choose a reason for hiding this comment

rajsesh Mar 30, 2017 • edited by msft-Jeyaram Loading

Choose a reason for hiding this comment

rajsesh Mar 30, 2017 • edited by msft-Jeyaram Loading

Choose a reason for hiding this comment

DHowett-MSFT Mar 30, 2017 • edited by msft-Jeyaram Loading

Choose a reason for hiding this comment

DHowett-MSFT Mar 30, 2017 • edited by msft-Jeyaram Loading

Choose a reason for hiding this comment

msft-Jeyaram Mar 30, 2017

Choose a reason for hiding this comment

DHowett-MSFT Mar 30, 2017 • edited by msft-Jeyaram Loading

Choose a reason for hiding this comment

msft-Jeyaram Mar 30, 2017

Choose a reason for hiding this comment

msft-Jeyaram commented Mar 30, 2017

MSFTFox Mar 30, 2017 • edited by msft-Jeyaram Loading

Choose a reason for hiding this comment

MSFTFox Mar 30, 2017 • edited by msft-Jeyaram Loading

Choose a reason for hiding this comment

msft-Jeyaram Mar 30, 2017

Choose a reason for hiding this comment

msft-Jeyaram commented Mar 31, 2017

rajsesh Mar 30, 2017 •

edited by msft-Jeyaram

Loading

rajsesh Mar 30, 2017 •

edited by msft-Jeyaram

Loading

rajsesh Mar 30, 2017 •

edited by msft-Jeyaram

Loading

rajsesh Mar 30, 2017 •

edited by msft-Jeyaram

Loading

rajsesh Mar 30, 2017 •

edited by msft-Jeyaram

Loading

DHowett-MSFT Mar 30, 2017 •

edited by msft-Jeyaram

Loading

DHowett-MSFT Mar 30, 2017 •

edited by msft-Jeyaram

Loading

DHowett-MSFT Mar 30, 2017 •

edited by msft-Jeyaram

Loading

MSFTFox Mar 30, 2017 •

edited by msft-Jeyaram

Loading

MSFTFox Mar 30, 2017 •

edited by msft-Jeyaram

Loading