UIImage in UIColor, which is of a pattern, should be using StrongId t…

…o better manage it's life time
microsoft · Mar 31, 2017 · 451877b · 451877b
1 parent 31f743c
commit 451877b
Showing 1 changed file with 2 additions and 10 deletions.
diff --git a/Frameworks/UIKit/UIColor.mm b/Frameworks/UIKit/UIColor.mm
@@ -223,7 +223,7 @@ rgb hsv2rgb(hsv in) {
 @implementation UIColor {
 @public
     enum BrushType _type;
-    UIImage* _image;
+    StrongId<UIImage> _image;
     woc::StrongCF<CGPatternRef> _pattern;
     __CGColorQuad _components;
     // Note: This should be part of the CGColor struct
@@ -510,7 +510,7 @@ - (UIColor*)initWithPatternImage:(UIImage*)image {
     }
 
     _pattern = _CGPatternCreateFromImage(pImg);
-    _image = [image retain];
+    _image = image;
     _type = cgPatternBrush;
 
     _components.r = 0.0f;
@@ -755,14 +755,6 @@ - (BOOL)isEqual:(UIColor*)other {
     }
 }
 
-/**
- @Status Interoperable
-*/
-- (void)dealloc {
-    [_image release];
-    [super dealloc];
-}
-
 /**
  @Status Stub
 */