fix a bug preventing a subclass property sharing a name with a type parameter from being accessed #56690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arameter from being accessed
typescript-bot
added
the
For Uncommitted Bug
|
@microsoft-github-policy-service agree |
|
The same issue is fixed by #56626. @RyanCavanaugh You might want to compare this solution with yours. |
|
@MartinJohns Why would I want to do that, to make myself feel bad?😆 I'll close this as it seems like @RyanCavanaugh's PR will be merged soon. I should have been more thorough review existing issues before looking at this anyways. I just thought unlike most of what I run into, it looked relatively approachable. |
He meant that Ryan should compare the solution in #56626 to this one (to see which one is better), I think. |
|
@fatcerberus Ahh, well that would be a very generous appraisal of the likelihood that I have something to contribute. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56689
I have very little context here so happy to adjust if there is a better way to resolve this. It just looked like it would be straightforward to resolve when I encountered so decided to give it a shot 🙏