Directly copy only the index signature in addition to declared properties #56626
Conversation
…ties Fixes microsoft#56620 Partial revert of microsoft#55252
typescript-bot
added
Author: Team
For Uncommitted Bug
|
@typescript-bot test this |
|
Heya @RyanCavanaugh, I've started to run the parallelized Definitely Typed test suite on this PR at 8d1b0c0. You can monitor the build here. Update: The results are in! |
|
Heya @RyanCavanaugh, I've started to run the diff-based top-repos suite on this PR at 8d1b0c0. You can monitor the build here. Update: The results are in! |
|
Heya @RyanCavanaugh, I've started to run the regular perf test suite on this PR at 8d1b0c0. You can monitor the build here. Update: The results are in! |
|
Heya @RyanCavanaugh, I've started to run the diff-based user code test suite on this PR at 8d1b0c0. You can monitor the build here. Update: The results are in! |
|
Heya @RyanCavanaugh, I've started to run the tarball bundle task on this PR at 8d1b0c0. You can monitor the build here. |
|
Heya @RyanCavanaugh, I've started to run the diff-based user code test suite (tsserver) on this PR at 8d1b0c0. You can monitor the build here. Update: The results are in! |
|
Heya @RyanCavanaugh, I've started to run the diff-based top-repos suite (tsserver) on this PR at 8d1b0c0. You can monitor the build here. Update: The results are in! |
|
Hey @RyanCavanaugh, I've packed this into an installable tgz. You can install it for testing by referencing it in your and then running There is also a playground for this build and an npm module you can use via |
|
@RyanCavanaugh Here are the results of running the user test suite comparing Everything looks good! |
|
LGTM 😉 |
|
@RyanCavanaugh Here are the results of running the user test suite comparing There were infrastructure failures potentially unrelated to your change:
Otherwise... Something interesting changed - please have a look. Details
|
|
@RyanCavanaugh Here they are:
CompilerComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
tsserverComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
StartupComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Hey @RyanCavanaugh, the results of running the DT tests are ready. |
|
@RyanCavanaugh Here are the results of running the top-repos suite comparing Everything looks good! |
|
@RyanCavanaugh Here are the results of running the top-repos suite comparing Something interesting changed - please have a look. DetailsServer exited prematurely with code unknown and signal SIGABRTAffected reposcalcom/cal.comRaw error text:RepoResults7/calcom.cal.com.rawError.txt in the artifact folder
Last few requests{"seq":780,"type":"request","command":"updateOpen","arguments":{"changedFiles":[],"closedFiles":[],"openFiles":[{"file":"@PROJECT_ROOT@/apps/web/abTest/middlewareFactory.ts","projectRootPath":"@PROJECT_ROOT@"}]}}
{"seq":781,"type":"request","command":"organizeImports","arguments":{"scope":{"type":"file","args":{"file":"@PROJECT_ROOT@/apps/web/abTest/middlewareFactory.ts"}},"skipDestructiveCodeActions":false}}
{"seq":782,"type":"request","command":"getOutliningSpans","arguments":{"file":"@PROJECT_ROOT@/apps/web/abTest/middlewareFactory.ts"}}
{"seq":783,"type":"request","command":"navto","arguments":{"searchValue":"a","maxResultCount":256}}
Repro steps
|
|
Added tests from new reports |
|
CI hit a network error 🙄 |
There was a problem hiding this comment.
This certainly fixes the issue and doesn't cause a regression on #55251.
I find it a bit unsatisfying that we don't copy all symbols like the comment points out though, and instead have to specifically copy index symbols.
I have half an idea that we could be copying all the symbols and modify addInheritedMembers to account for the type (parameter) problem by merging symbols.
|
@typescript-bot cherry-pick this to release-5.3 |
|
Heya @RyanCavanaugh, I've started to cherry-pick this into |
|
Hey @RyanCavanaugh, I've created #56709 for you. |
…e-5.3 (#56709) Co-authored-by: Ryan Cavanaugh <[email protected]>
Fixes #56620
Partial revert of #55252