-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump LKG and package.json to 5.0.0-dev.20230112 #51787
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤷🏻♂️
So, maybe I just wait for #51771 to be merged before doing this. |
I've modified this PR to instead bump $ rm -rf lib && cp -r ./node_modules/typescript/lib . && git restore ./lib/.gitattributes Which does basically the same thing that I used to do with This has the benefit of keeping everything in sync and letting I'm curious what people's opinion is of that (it's in the same spirit as my git checkout-ing, so, I kinda like it, but I also feel like we could totally forego LKG altogether). |
1cf625d
to
c3be4fb
Compare
Thinking about this again, the main benefit is being able to use the new inference features in #49929 without breaking ts-eslint, since without bumping node_modules, it will use 4.9 and not have the new inference features. |
c0f843f
to
0af6109
Compare
I've added a task which automates installing a new version of the nightly into package.json/node_modules and copying it to LKG:
We can of course update this out of band when needed, but to bring them back in sync again, this task can be used. Eventually per #52199 we'll drop lib entirely, in which case this won't be needed anymore. |
I'll redo this PR tomorrow once #51771 is in. |
0af6109
to
425835f
Compare
This PR should be ready for review; all needed PRs are merged in main and released in nightly. |
name: "bump-lkg-to-nightly", | ||
description: "Bumps typescript in package.json to the latest nightly and copies it to LKG.", | ||
run: async () => { | ||
await exec("npm", ["install", "--save-dev", "--save-exact", "typescript@next"]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This hardcodes @next
, but feasibly we may want (after 5.0 release) to switch to a stable build. But, I suspect that by then, we'll have deleted LKG anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Presumably we keep manually bumping the LKG in main
for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, when required for one reason or another.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But, this won't be updated in the nightly package-lock update, since they'd get out of sync, and keeping them in sync so will create loads of churn (the antithesis of what we're hoping to get out of this ordeal).
425835f
to
627bcea
Compare
name: "bump-lkg-to-nightly", | ||
description: "Bumps typescript in package.json to the latest nightly and copies it to LKG.", | ||
run: async () => { | ||
await exec("npm", ["install", "--save-dev", "--save-exact", "typescript@next"]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Presumably we keep manually bumping the LKG in main
for now?
package.json
/node_modules
to5.0.0-dev.20230112
with an override to force its usage (even though it's a major version bump).hereby bump-lkg-to-nightly
) which automates bumpingpackage.json
and LKG in lockstep, until we eventually drop LKG on main.This PR looks huge because #51699 effectively completely rewrote
tsserver.js
.