Show implied options in --showConfig #56701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
|
@typescript-bot perf test this |
|
Heya @andrewbranch, I've started to run the regular perf test suite on this PR at 1032991. You can monitor the build here. Update: The results are in! |
andrewbranch
commented
Dec 6, 2023
| /** @internal */ | ||
| export const getEmitModuleDetectionKind = computedOptions.moduleDetection.computeValue; | ||
| /** @internal */ | ||
| export const getIsolatedModules = computedOptions.isolatedModules.computeValue; |
There was a problem hiding this comment.
One advantage is that these functions now automatically say what they depend on in their parameter type. The signature of this one, for example, is (compilerOptions: Pick<CompilerOptions, "isolatedModules" | "verbatimModuleSyntax">) => boolean
|
@andrewbranch Here they are:
CompilerComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
tsserverComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
StartupComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
jakebailey
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
This seems reasonable to me.
I know the perf doesn't seem to be affected, but I do wonder if we should lift all of these calls in the checker upward so they're all precalculated and local, rather than continually calculating them. e.g. we call getEmitModuleResolutionKind and getESModuleInterop a looot. As evidenced by this change, they all strictly depend on compilerOptions, so could be known immediately.
sheetalkamat
requested changes
Dec 7, 2023
andrewbranch
commented
Dec 7, 2023
| moduleResolution: computedCompilerOption("moduleResolution", ["module", "target"], (compilerOptions): ModuleResolutionKind => { | ||
| let moduleResolution = compilerOptions.moduleResolution; | ||
| if (moduleResolution === undefined) { | ||
| export const computedOptions = createComputedCompilerOptions({ |
There was a problem hiding this comment.
Thanks @Andarist for helping with this tricky inference 🌟
This only works in recent nightlies, hence the “LKG” bump (cc @jakebailey)
There was a problem hiding this comment.
I don't mind bumping the TS version, though I am wondering which PR was needed to make this pattern work (and of course if there's any change at all that we could avoid it 😅).
But yeah, this pattern is nicer than the previous IMO.
There was a problem hiding this comment.
It’s the recent improvement from #55811 . It was merged in just last week :)
sheetalkamat
reviewed
Dec 8, 2023
Andarist
reviewed
Dec 8, 2023
Andarist
reviewed
Dec 8, 2023
sheetalkamat
reviewed
Dec 8, 2023
sheetalkamat
reviewed
Dec 8, 2023
sheetalkamat
reviewed
Dec 8, 2023
sheetalkamat
reviewed
Dec 8, 2023
sheetalkamat
reviewed
Dec 8, 2023
sheetalkamat
reviewed
Dec 8, 2023
sheetalkamat
reviewed
Dec 8, 2023
sheetalkamat
reviewed
Dec 8, 2023
sheetalkamat
reviewed
Dec 8, 2023
sheetalkamat
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes my minor annoyance from earlier today
--showConfigon this tsconfig:{ "compilerOptions": { "module": "NodeNext" } }Before:
{ "compilerOptions": { "module": "nodenext" }, "files": [ "./main.ts", ] }After:
{ "compilerOptions": { "module": "nodenext", "target": "esnext", "moduleResolution": "nodenext", "moduleDetection": "force", "esModuleInterop": true, "allowSyntheticDefaultImports": true, "useDefineForClassFields": true }, "files": [ "./main.ts" ] }