Grab '@param' tags from initializers #4979
Merged
+163
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only do this for a (parenthesized) function expression, arrow function, or class expression with a constructor. In the presence of a class expression, if there are multiple constructor declarations, the parameters are acquired from the first one.
|
|
||
| /** | ||
| * Digs into an an initializer or RHS operand of an assignment operation | ||
| * to get the parameters from an apst signature corresponding to a |
|
👍 |
3 similar comments
|
👍 |
|
👍 |
|
👍 |
DanielRosenwasser
added a commit
that referenced
this pull request
Sep 26, 2015
Grab '@param' tags from initializers
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses @zhengbli's concern in #4978 (comment).
This PR enables us to grab parameters from a "simple"/"canonical" callable/constructable expression in a variable statement with a single declaration.
We only do this for a function expression, arrow function, or class expression with a constructor, or any of the aforementioned in nested parentheses.
In the presence of a class expression, if there are multiple constructor declarations, the parameters are acquired from the first one.