Expand JSDoc template generation locations (to 'master') #4978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also updated TODO
DanielRosenwasser
changed the title
| return undefined; | ||
| } | ||
|
|
||
| let parameters = containingFunction.parameters; | ||
| let parameters = isFunctionLike(commentOwner) ? commentOwner.parameters : emptyArray; |
There was a problem hiding this comment.
If the commentOwner is a VariableStatement that contains a function expression, shouldn't we provide parameters too? E.g.
var foo = function (p0, p1, p2) { };
There was a problem hiding this comment.
Yes, but I think we'll do that in a separate pull request.
DanielRosenwasser
added a commit
that referenced
this pull request
Sep 25, 2015
Expand JSDoc template generation locations (to 'master')
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4962 but in
master.This pull request addresses portions of #4447.
We currently now cover