Lowercase type reference directives when determining to reuse program structure (just like when we create new program) #26944
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change when program contains a file that references UpperCase package using typeReferenceDirective, trying to reuse the old program we will resolve type reference directive as "UpperCasePackage" and that can succeed, thus us identifying that program structure to reuse is only module safe (and cant be used completely because typereference directive from old prgram to "uppercasepackage" and new "UpperCasePackage" wont match). Now when creating the actual new program we will resolve type reference directive with "UpperCasePacakage" while doing so we will release the "UpperCasePackage" from ResolutionCache and thus having deferred watch for "UpperCasePackage" that is now refCount to 0 and failing in assert later while finishing the resolution cache.