Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto type reference directives do not lowercase the typing name #26948

Closed
sheetalkamat opened this issue Sep 6, 2018 · 2 comments
Closed

Auto type reference directives do not lowercase the typing name #26948

sheetalkamat opened this issue Sep 6, 2018 · 2 comments
Assignees
Labels
Needs Investigation This issue needs a team member to investigate its status.
Milestone

Comments

@sheetalkamat
Copy link
Member

sheetalkamat commented Sep 6, 2018

As part of #9824 all type reference directives are lower cased so type="somePackage" results in looking for type reference of somepackage instead.

When including the auto type directives, we include list of typings from user or get the package names from typeRoots (where if config doesn't provide it, it will be node_modules/@types)
The package names read here are not lower cased. Thus this leaves a discrepancy between these type sources included and typereference directives included resulting in confusion for packages in these auto type directives to reference other packages at same level.

Eg.
If auto type references are: "UpperCasePackage", "somepackage", and if somepackage needs to reference this UpperCasePackage it has no way to do so correctly.

Found while working on #26944

@sheetalkamat
Copy link
Member Author

This is still issue irrespective of #57681

@jakebailey
Copy link
Member

Ah, my mistake, I mistook this as something to do with emit.

@jakebailey jakebailey removed the Fix Available A PR has been opened for this issue label Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Investigation This issue needs a team member to investigate its status.
Projects
None yet
Development

No branches or pull requests

4 participants