Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed non-imports and non-working imports from sample #108

Merged
merged 2 commits into from
Nov 4, 2019
Merged

Removed non-imports and non-working imports from sample #108

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d472bcb
Removed non-imports and non-working imports from sample
DanielRosenwasser Nov 4, 2019
2b28a4c
Update Automatic Type Acquisition.ts
DanielRosenwasser Nov 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 6 additions & 20 deletions Examples/en/Playground/Language/Automatic Type Acquisition.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,32 +17,18 @@ import {danger} from "danger"

danger.github

// This handles sub-dependencies also, in this case
// the danger's types depends on @octokit/rest also.
// This handles transitive dependencies also, so in this case,
// danger depends on @octokit/rest also.

danger.github.api.pulls.createComment()

// the Type Acquisition will also take node's special case
// dependencies into account and pull all of the node types
// Type acquisition will also take Node's built-in modules
// into account and pull in Node's type declarations
// when you use any of those dependencies. Note, these
// tend to take a bit longer than the others (because there
// is quite a lot of types to download.)
// tend to take a bit longer than the others since there's
// quite a lot of types to download!

import {readFileSync} from "fs"

const inputPath = "my/path/file.ts"
readFileSync(inputPath, "utf8")

// The type acquisition doesn't just support modern ES2015
// module imports, there is support for require too.

const path = require("path")
const outputPath = path.join("my", "path", "file.js")

// This is still beta-y because we've not got dependencies
// like lodash to work with it yet. On the other hand, it
// also supports getting types using deno-style imports:

import {Printer, Config, format} from "https://deno.land/[email protected]/testing/format.ts"