Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed non-imports and non-working imports from sample #108

Merged
merged 2 commits into from
Nov 4, 2019

Conversation

DanielRosenwasser
Copy link
Member

The require call doesn't work in TS files, and the .ts path was still causing errors to be reported

The `require` call doesn't work in TS files, and the `.ts` path was still causing errors to be reported
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2019

Messages
📖

Deployed to a PR branch

Typos for Automatic Type Acquisition.ts

Line Typo
21 // danger depends on @octokit/rest also.
Got false positives?

Make changes to the global settings spellcheck.json in /artsy/peril-settings.

Generated by 🚫 dangerJS against 2b28a4c

@orta
Copy link
Contributor

orta commented Nov 4, 2019

👍

@orta orta merged commit d985bd6 into master Nov 4, 2019
@orta
Copy link
Contributor

orta commented Nov 4, 2019

I'd like to get the playground to suppress these two errors eventually and bring these back at some point

@DanielRosenwasser
Copy link
Member Author

Well the second is an error, but the require call just doesn't work unless you're in a JS file.

@orta
Copy link
Contributor

orta commented Nov 4, 2019

In this case, import compose from "https://deno.land/x/denofun/lib/compose.ts" is not an error in Deno. See: https://www.typescriptlang.org/play/index.html?e=5#example/typescript-with-deno

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants