Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test workarounds for an ASAN bug #4118

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Remove test workarounds for an ASAN bug #4118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions tests/std/tests/GH_002030_asan_annotate_string/test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1738,7 +1738,6 @@ void test_exceptions() {
assert(verify_string(append_iterator));
}

#if 0 // TRANSITION, DevCom-1527920
str append_iterator_sso{input_sso};
try {
assert(verify_string(append_iterator_sso));
Expand All @@ -1747,7 +1746,6 @@ void test_exceptions() {
} catch (...) {
assert(verify_string(append_iterator_sso));
}
#endif

str append_input_iterator{input};
try {
Expand All @@ -1758,14 +1756,12 @@ void test_exceptions() {
assert(verify_string(append_input_iterator));
}

#if 0 // TRANSITION, DevCom-1527920
str append_input_iterator_sso{input_sso};
try {
append_input_iterator_sso.append(input_iter_data.begin(), input_iter_data.end());
} catch (...) {
assert(verify_string(append_input_iterator_sso));
}
#endif
}

{ // assign
Expand All @@ -1778,15 +1774,13 @@ void test_exceptions() {
assert(verify_string(assign_iterator));
}

#if 0 // TRANSITION, DevCom-1527920
str assign_iterator_sso{input_sso};
try {
assert(verify_string(assign_iterator_sso));
assign_iterator_sso.assign(begin(iter_data), end(iter_data));
} catch (...) {
assert(verify_string(assign_iterator_sso));
}
#endif

str assign_input_iterator{input};
try {
Expand All @@ -1797,7 +1791,6 @@ void test_exceptions() {
assert(verify_string(assign_input_iterator));
}

#if 0 // TRANSITION, DevCom-1527920
str assign_input_iterator_sso{input_sso};
try {
assert(verify_string(assign_input_iterator_sso));
Expand All @@ -1806,7 +1799,6 @@ void test_exceptions() {
} catch (...) {
assert(verify_string(assign_input_iterator_sso));
}
#endif
}

{ // insert
Expand All @@ -1819,7 +1811,6 @@ void test_exceptions() {
assert(verify_string(insert_iterator));
}

#if 0 // TRANSITION, DevCom-1527920
str insert_iterator_sso{input_sso};
try {
assert(verify_string(insert_iterator_sso));
Expand All @@ -1828,7 +1819,6 @@ void test_exceptions() {
} catch (...) {
assert(verify_string(insert_iterator_sso));
}
#endif

str insert_input_iterator{input};
try {
Expand All @@ -1839,7 +1829,6 @@ void test_exceptions() {
assert(verify_string(insert_input_iterator));
}

#if 0 // TRANSITION, DevCom-1527920
str insert_input_iterator_sso{input_sso};
try {
assert(verify_string(insert_input_iterator_sso));
Expand All @@ -1849,7 +1838,6 @@ void test_exceptions() {
} catch (...) {
assert(verify_string(insert_input_iterator_sso));
}
#endif
}
}

Expand Down