Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test workarounds for an ASAN bug #4118

Conversation

StephanTLavavej
Copy link
Member

I noticed that GH_002030_asan_annotate_string had a bunch of workarounds for DevCom-1527920 "[ASAN] Exceptions invalidate annotation of stack based buffer", but it no longer appears to repro. Let's see if we can activate this test coverage now. I'm isolating this into a separate PR in case something goes wrong.

The ASAN configurations are passing:

D:\GitHub\STL\out\x64>git status
On branch dry-cleaning-2-remove-test-workarounds
Your branch is up to date with 'stephan/dry-cleaning-2-remove-test-workarounds'.

nothing to commit, working tree clean

D:\GitHub\STL\out\x64>python tests\utils\stl-lit\stl-lit.py -o testing_x64.log  %STL%\tests\std\tests\GH_002030_asan_annotate_string
-- Testing: 46 tests, 32 workers --
PASS: std :: tests/GH_002030_asan_annotate_string:00 (1 of 46)
[...]
PASS: std :: tests/GH_002030_asan_annotate_string:45 (46 of 46)

Testing Time: 67.17s
  Passed: 46

…nnotation of stack based buffer" which no longer repros.
@StephanTLavavej StephanTLavavej added test Related to test code ASan Address Sanitizer labels Oct 23, 2023
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner October 23, 2023 15:45
@StephanTLavavej StephanTLavavej self-assigned this Oct 24, 2023
@StephanTLavavej
Copy link
Member Author

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 6a366ad into microsoft:main Oct 25, 2023
@StephanTLavavej StephanTLavavej deleted the dry-cleaning-2-remove-test-workarounds branch October 25, 2023 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASan Address Sanitizer test Related to test code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants