Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Power Rename] not opening anymore #14076

Closed
Jay-o-Way opened this issue Oct 29, 2021 · 37 comments
Closed

[Power Rename] not opening anymore #14076

Jay-o-Way opened this issue Oct 29, 2021 · 37 comments
Assignees
Labels
Product-PowerRename Refers to the PowerRename PowerToy Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@Jay-o-Way
Copy link
Collaborator

Jay-o-Way commented Oct 29, 2021

Microsoft PowerToys version

0.49

Area(s) with issue?

PowerRename

Steps to reproduce

Just updated to 0.49 on my Surface Pro. Tried to use Power Rename on a folder.

✔️ Expected Behavior

Power Rename UI

❌ Actual Behavior

Short activity circle in the Windows mouse cursor. Power Rename is mentioned in Task Manager for about 1 second and then is gone. No UI.
Image Resizer works well.

Surface: Persisted after restarting Windows. Opening directly (from folder/exe) gives same result.
Desktop: The UI opens for about a second and then crashes.

Note: haven't restarted Windows at time of writing this. I did restart PowerToys.

@Jay-o-Way Jay-o-Way added Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Oct 29, 2021
@htcfreek
Copy link
Collaborator

@Jay-o-Way
Can you please upload a report? Maybe there is a crash.

@Jay-o-Way
Copy link
Collaborator Author

@Jay-o-Way Jay-o-Way changed the title [Power Rename] not opening when clicked in menu, first time after update [Power Rename] not opening menu anymore Oct 29, 2021
@Jay-o-Way
Copy link
Collaborator Author

Jay-o-Way commented Oct 29, 2021

Persisted after restarting Windows. Opening directly (from folder/exe) gives same result.

@Jay-o-Way Jay-o-Way changed the title [Power Rename] not opening menu anymore [Power Rename] not opening anymore Oct 29, 2021
@sobraonain
Copy link

I am also experiencing this issue of Power Rename not opening after upgrading to 0.49.

Asus Zenbook running Windows 10, OS build 19043.1320.

Bug report attached: PowerToysReport_2021-10-30-01-06-48.zip

@franky920920 franky920920 added the Product-PowerRename Refers to the PowerRename PowerToy label Oct 30, 2021
@htcfreek
Copy link
Collaborator

I have the same bug and saw that there is an crash report in event viewer:

PowerToysReport_2021-10-30-11-05-38.zip

@htcfreek
Copy link
Collaborator

@jaimecbernardo, @crutkas: Good for a Hot-fix?

@htcfreek htcfreek added the Severity-Regression This was working in a previous release label Oct 30, 2021
@Jay-o-Way
Copy link
Collaborator Author

Desktop crashes too, here shows UI fro about 2 seconds.

@htcfreek
Copy link
Collaborator

@niels9001
Is there any options to log every exception that occurs in the ux code? The logs are useless.

@niels9001
Copy link
Contributor

@stefansjfw fyi

@stefansjfw
Copy link
Collaborator

I'm looking into it.. @Jay-o-Way @htcfreek Could you post here the event viewer log? I don't see it in already attached logs. Thanks!

@htcfreek
Copy link
Collaborator

htcfreek commented Nov 1, 2021

I'm looking into it.. @Jay-o-Way @htcfreek Could you post here the event viewer log? I don't see it in already attached logs. Thanks!

Sure. But it isn't helpful. Only a general crash in PowerRename.exe. No stack trace. Would be helpful to add code to a dev build for logging exceptions at the highest level.

@stefansjfw
Copy link
Collaborator

@htcfreek Can you try installing Microsoft Visual C++ redistributable and check whether PowerRename works after that ?

@htcfreek
Copy link
Collaborator

htcfreek commented Nov 1, 2021

@htcfreek Can you try installing Microsoft Visual C++ redistributable and check whether PowerRename works after that ?

which version?

@stefansjfw
Copy link
Collaborator

Visual Studio 2015, 2017, 2019, and 2022 - x64

@htcfreek
Copy link
Collaborator

htcfreek commented Nov 1, 2021

Visual Studio 2015, 2017, 2019, and 2022 - x64

This isn't installed. I am going to test it.

Event log:

Name der fehlerhaften Anwendung: PowerRename.exe, Version: 0.0.0.0, Zeitstempel: 0x617c36c0
Name des fehlerhaften Moduls: PowerRename.exe, Version: 0.0.0.0, Zeitstempel: 0x617c36c0
Ausnahmecode: 0xc0000409
Fehleroffset: 0x000000000008e73d
ID des fehlerhaften Prozesses: 0x3a74
Startzeit der fehlerhaften Anwendung: 0x01d7ce46ee7c8805
Pfad der fehlerhaften Anwendung: C:\Program Files\PowerToys\modules\PowerRename\PowerRename.exe
Pfad des fehlerhaften Moduls: C:\Program Files\PowerToys\modules\PowerRename\PowerRename.exe
Berichtskennung: 32669138-5832-4517-aa8c-d5e13e665cf2
Vollständiger Name des fehlerhaften Pakets: 
Anwendungs-ID, die relativ zum fehlerhaften Paket ist: 

@htcfreek
Copy link
Collaborator

htcfreek commented Nov 1, 2021

Visual Studio 2015, 2017, 2019, and 2022 - x64

@stefansjfw , @Jay-o-Way
Installing the runtime fixes the problem. Great. Should be added to installer and readme.md.

@franky920920
Copy link
Contributor

Visual Studio 2015, 2017, 2019, and 2022 - x64

@stefansjfw , @Jay-o-Way Installing the runtime fixes the problem. Great. Should be added to installer and readme.md.

Converting to #issue-docs for this.

@franky920920 franky920920 added Issue-Docs Documentation issue that needs to be improved and removed Issue-Bug Something isn't working Severity-Regression This was working in a previous release labels Nov 1, 2021
@stefansjfw
Copy link
Collaborator

Thanks for checking! I'm checking how to include it in installer. For now, quick fix is installing it manually

@Jay-o-Way
Copy link
Collaborator Author

installing it manually

Okay. Which version? Or do i need all?

@stefansjfw
Copy link
Collaborator

stefansjfw commented Nov 1, 2021

Visual Studio 2015, 2017, 2019, and 2022 - x64

https://docs.microsoft.com/en-us/cpp/windows/latest-supported-vc-redist?view=msvc-160

@Jay-o-Way
Copy link
Collaborator Author

Okay if that's all, I'll check if i can add this to my pr. It's waiting to be merged 🤞🏻

@stefansjfw stefansjfw added the Status-In progress This issue or work-item is under development label Nov 1, 2021
@stefansjfw stefansjfw self-assigned this Nov 1, 2021
@stefansjfw
Copy link
Collaborator

@Jay-o-Way No docs updates needed. Everything needed is shipped within PT installation with this PR

@htcfreek
Copy link
Collaborator

htcfreek commented Nov 1, 2021

@Jay-o-Way No docs updates needed. Everything needed is shipped within PT installation with this PR

I disagree. For dotnet we have an entry too.

@stefansjfw
Copy link
Collaborator

@Jay-o-Way No docs updates needed. Everything needed is shipped within PT installation with this PR

I disagree. For dotnet we have an entry too.

We are not installing anything in addition to PT here (PR)..
We already use/ship same runtime libs for ImageResizer, PowerLauncher, etc.. I just reused these for PowerRename now.

@htcfreek
Copy link
Collaborator

htcfreek commented Nov 1, 2021

@Jay-o-Way No docs updates needed. Everything needed is shipped within PT installation with this PR

I disagree. For dotnet we have an entry too.

We are not installing anything in addition to PT here (PR)..
We already use/ship same runtime libs for ImageResizer, PowerLauncher, etc.. I just reused these for PowerRename now.

Okay. Make sense.

@Jay-o-Way

This comment has been minimized.

@htcfreek
Copy link
Collaborator

htcfreek commented Nov 1, 2021

Still, fact is that it needs to be installed in order for PowerToys to run properly. That counts as "required" to me. Therefore adding it to install.md

Not it doesn't need to install. Only some parts (dlls) of the runtime are shipped with PT setup and copied into Modul folders.

@crutkas
Copy link
Member

crutkas commented Nov 1, 2021

so is the installer missing bits due to the rewrite?

@crutkas crutkas removed Issue-Docs Documentation issue that needs to be improved Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Nov 1, 2021
@crutkas
Copy link
Member

crutkas commented Nov 1, 2021

@stefansjfw can we test on a clean VM install with 0.49.1 to verify

@htcfreek
Copy link
Collaborator

htcfreek commented Nov 1, 2021

@stefansjfw can we test on a clean VM install with 0.49.1 to verify

After installing vc runtime 2015-2019 it works on my system.

@stefansjfw
Copy link
Collaborator

@stefansjfw can we test on a clean VM install with 0.49.1 to verify

Already did this and confirmed that issue is there. Linked PR fixes the issue.

@stefansjfw stefansjfw added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels Nov 2, 2021
@ghost
Copy link

ghost commented Nov 26, 2021

After installing Microsoft Visual C++ redistributable it worked for one time. After a reboot the application starts and closes immediatelly. You can see the application for one or two seconds and then it will be terminated, Any thoughts about it? Using Win 10

@stefansjfw
Copy link
Collaborator

@mfitzen I believe you are now hitting different issue tracked here #14356. This should also be fixed in the next release which should be coming soon (in a few days).

@crutkas
Copy link
Member

crutkas commented Nov 30, 2021

This is fixed in 0.51. Please head over to our releases and get the update! https://aka.ms/installpowertoys

@crutkas crutkas closed this as completed Nov 30, 2021
@ghost
Copy link

ghost commented Nov 30, 2021

@mfitzen I believe you are now hitting different issue tracked here #14356. This should also be fixed in the next release which should be coming soon (in a few days).

Seems to work with the new release. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Product-PowerRename Refers to the PowerRename PowerToy Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Development

No branches or pull requests

7 participants