Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PowerRename runs for hours at high CPU without UI if invoked on certain areas of File Explorer #14576

Closed
1 task done
typpos opened this issue Nov 22, 2021 · 11 comments
Closed
1 task done
Labels
Issue-Bug Something isn't working Needs-Team-Response An issue author responded so the team needs to follow up Product-PowerRename Refers to the PowerRename PowerToy Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@typpos
Copy link

typpos commented Nov 22, 2021

Microsoft PowerToys version

0.49.1

Running as admin

  • Yes

Area(s) with issue?

PowerRename

Steps to reproduce

Summary:
If invoked on certain File Explorer elements, PowerRename starts, does not display any UI and runs at high CPU usage for hours.

Steps:

  1. Start Windows File Explorer
  2. In Navigation Pane, select "Quick Access"
  3. From View menu select "medium size icons"
  4. In main area, select and then right click on heading "Frequent folders"
  5. From context menu, select "PowerRename"

✔️ Expected Behavior

Option 1: PowerRename is not available in context menu

Option 2: PowerRename displays a user interface.

❌ Actual Behavior

PowerRename starts and runs at high CPU (as per Task Manager) but does not display any UI.

(I killed the lingering process after around 3 hours.)

Other Software

Windows 10 Pro (10.0.19043)

ScreenRecording

@typpos typpos added Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Nov 22, 2021
@franky920920 franky920920 added the Product-PowerRename Refers to the PowerRename PowerToy label Nov 22, 2021
@franky920920
Copy link
Contributor

Maybe #14356
What resolution and the DPI scale are your monitor using?

@franky920920 franky920920 added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Nov 22, 2021
@typpos
Copy link
Author

typpos commented Nov 22, 2021

What resolution and the DPI scale are your monitor using?

Dual monitor setup. 2560x1440; 27".
Scale setting is 100% if that's what you're asking. It's not a high DPI monitor.

@ghost ghost added Needs-Team-Response An issue author responded so the team needs to follow up and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Nov 22, 2021
@franky920920
Copy link
Contributor

franky920920 commented Nov 22, 2021

Just to confirm, can you set your resolution to either lower than:

  • 1600x900 with 125%
  • 1920x1080 with 100%

And see if you can launch PowerRename. Thank you

@franky920920 franky920920 added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Team-Response An issue author responded so the team needs to follow up labels Nov 22, 2021
@typpos
Copy link
Author

typpos commented Nov 22, 2021

to be sure, PowerRename works fine for normal usage. I raised the issue just in case the PowerRename context menu is registered/enabled for the Windows File Explorer items that aren't to be renameable, like special folders.

@ghost ghost added Needs-Team-Response An issue author responded so the team needs to follow up and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Nov 22, 2021
@typpos
Copy link
Author

typpos commented Nov 22, 2021

I confirm. Same problem with 1920x1080 @ 100%, when clicking on File Explorer > Quick Access > Frequent Folders.

@typpos
Copy link
Author

typpos commented Nov 22, 2021

After some more testing:

  1. Same problem when I try to PowerRename a folder with a large subdirectory tree. So, it's not an issue specific to special folders or group headings.
  2. SysInternals ProcessMonitor shows that PowerRename parses the directory tree in chunks, pauses for a long time after each chunk, then continues to parse.
  3. At start, for a few seconds, there actually is a UI: An invisible (fully transparent) small window at the top left of the screen. It turns mouse cursor to "waiting" shape. Clicking invokes Windows "not responding; kill?" dialog.

"Expected behaviour":

  • For large file sets (intentional or accidental), PowerRename should start by showing a valid UI and then start parsing, preferrably in an interrruptible nad UI-responsive manner.
  • Maybe review implementation of UI builder or parser. There is no obvious reason for the long pauses between reading chunks of file info. Maybe it chokes on creating a crazy large UI.

@franky920920
Copy link
Contributor

franky920920 commented Nov 22, 2021

@typpos Thanks for clarifying your issue! Sorry for misunderstanding. :)
Valid issue to fix. Thank you.

cc: @stefansjfw

@htcfreek
Copy link
Collaborator

For me it sound that Powername is following the shortcut paths.

@Jay-o-Way
Copy link
Collaborator

I had some issues a while back too. My solution is in this comment .

@stefansjfw
Copy link
Collaborator

Same problem when I try to PowerRename a folder with a large subdirectory tree. So, it's not an issue specific to special folders or group headings.

This looks like high cpu&memory performance issue tracked here #14219. It's fixed and will be included in next PT release.

I tried renaming Frequent folders like shown in description and with latest fixes I'm able to do so. Of course it takes some tome as there are 60K+ items&subitems (in my case).. You might have a lot more items there.. possibly hundreds of thousands items so memory limit can be hit and PowerRename could crash in the end. If not it will take some time but it'll load items and UI will be shown.

For large file sets (intentional or accidental), PowerRename should start by showing a valid UI and then start parsing, preferrably in an interrruptible nad UI-responsive manner.

Regarding this, you have a good point and we have this in our backlog. Some kind of Progress bar/dialog will be added in near future.

Also, you're right once again, PowerRename can't rename special folders like e.g. "Downloads", Local disks, etc.

@stefansjfw
Copy link
Collaborator

Closing as a duplicate of #14219

@stefansjfw stefansjfw added the Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. label Nov 23, 2021
@crutkas crutkas removed the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug Something isn't working Needs-Team-Response An issue author responded so the team needs to follow up Product-PowerRename Refers to the PowerRename PowerToy Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

6 participants