Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up #755 #648 #897

Merged
merged 3 commits into from
Jan 6, 2022
Merged

Conversation

BernieWhite
Copy link
Member

PR Summary

Fixes #755
Fixes #648

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • Change is not breaking
  • This PR is ready to merge and is not Work in Progress
  • Code changes
    • Have unit tests created/ updated
    • Link to a filed issue
    • Change log has been updated with change under unreleased section

@BernieWhite BernieWhite requested a review from a team as a code owner January 5, 2022 13:13
Copy link
Contributor

@ArmaanMcleod ArmaanMcleod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BernieWhite Looks great. Fixed some typos, hope thats ok with you.

src/PSRule/Pipeline/PipelineContext.cs Show resolved Hide resolved
@BernieWhite BernieWhite merged commit 1fc265f into microsoft:main Jan 6, 2022
@BernieWhite BernieWhite deleted the bewhite/clean-v2-removal branch January 6, 2022 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove default baseline from module manifest Require strong apiVersion for resource types
2 participants