Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default baseline from module manifest #755

Closed
BernieWhite opened this issue Jul 29, 2021 · 0 comments · Fixed by #897
Closed

Remove default baseline from module manifest #755

BernieWhite opened this issue Jul 29, 2021 · 0 comments · Fixed by #897
Assignees
Labels
breaking-change Changes that affect existing functionality feature: baselines Issues that affect baselines
Milestone

Comments

@BernieWhite
Copy link
Member

BernieWhite commented Jul 29, 2021

Issue #809 implements configuring default baseline in module configuration.

This issue removes support for module manifest configuration.

@{
  # Private data to pass to the module specified in RootModule/ModuleToProcess. This may also contain a PSData hashtable with additional module metadata used by PowerShell.
  PrivateData = @{
      PSData = @{
          # Tags applied to this module. These help with module discovery in online galleries.
          Tags = @('PSRule-rules')
      }
      PSRule = @{
          Baseline = 'Enterprise.Default'
      }
  }
}
@BernieWhite BernieWhite added enhancement New feature or request breaking-change Changes that affect existing functionality labels Jul 29, 2021
@BernieWhite BernieWhite added this to the v2.0.0 milestone Jul 29, 2021
@BernieWhite BernieWhite added feature: baselines Issues that affect baselines and removed enhancement New feature or request labels Jul 29, 2021
@BernieWhite BernieWhite changed the title Migrate default baseline to module configuration Remove default baseline to module configuration Sep 29, 2021
@BernieWhite BernieWhite changed the title Remove default baseline to module configuration Remove default baseline from module manifest Jan 5, 2022
@BernieWhite BernieWhite self-assigned this Jan 5, 2022
BernieWhite added a commit to BernieWhite/PSRule that referenced this issue Jan 5, 2022
@BernieWhite BernieWhite mentioned this issue Jan 5, 2022
7 tasks
BernieWhite added a commit that referenced this issue Jan 6, 2022
* Clean up #755 #648

* Fix typos

Co-authored-by: ArmaanMcleod <[email protected]>
@BernieWhite BernieWhite mentioned this issue Mar 25, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Changes that affect existing functionality feature: baselines Issues that affect baselines
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant