Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed source scope in multi-module runs #1053 #1057

Merged
merged 2 commits into from
Apr 19, 2022
Merged

Fixed source scope in multi-module runs #1053 #1057

merged 2 commits into from
Apr 19, 2022

Conversation

BernieWhite
Copy link
Member

PR Summary

  • Fixed source scope not updated in multi-module runs.
    • Several properties of rule and language block elements have been renamed to improve consistency.
    • From v3 custom scripts may not work correctly until you update these names.

Fixes #1053

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • Change is not breaking
  • This PR is ready to merge and is not Work in Progress
  • Code changes
    • Have unit tests created/ updated
    • Link to a filed issue
    • Change log has been updated with change under unreleased section

@BernieWhite BernieWhite added this to the v2.0.1 milestone Apr 16, 2022
@BernieWhite BernieWhite requested a review from a team as a code owner April 16, 2022 06:57
@BernieWhite BernieWhite removed this from the v2.0.1 milestone Apr 16, 2022
@BernieWhite BernieWhite merged commit 13a7d9b into microsoft:main Apr 19, 2022
@BernieWhite BernieWhite deleted the bewhite/fix-module-scoping branch April 19, 2022 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Source scope not updated in multi-module runs
1 participant
@BernieWhite