Fixing tests, again #11118
Merged
Fixing tests, again #11118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zee2
requested review from
keveleigh,
david-c-kline,
RogPodge and
MaxWang-MS
as code owners
keveleigh
reviewed
Oct 20, 2022
com.microsoft.mrtk.input/Tests/Runtime/Utilities/InputTestUtilities.cs
Outdated
Show resolved
Hide resolved
com.microsoft.mrtk.input/Tests/Runtime/FuzzyGazeInteractorTests.cs
Outdated
Show resolved
Hide resolved
keveleigh
previously approved these changes
Oct 20, 2022
keveleigh
approved these changes
Oct 20, 2022
RogPodge
approved these changes
Oct 20, 2022
drusk-unity
pushed a commit
to drusk-unity/MixedRealityToolkit-Unity
that referenced
this pull request
Jun 26, 2023
* Removing smoothing from hand ray during unit tests * Cont. * Adding AimAt utility * Test fixes * Removing unnecessary things from DescribableObjectTests * Fixing System.Collections error * Fixing stateviz issues * Update com.microsoft.mrtk.input/Tests/Runtime/FuzzyGazeInteractorTests.cs Co-authored-by: Kurtis <[email protected]> * Fixing InFrontOfUser * PR feedback Co-authored-by: Kurtis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
There's been some test rot over the past week or so. We're working on getting PRs blocking on failing unit tests so this doesn't keep happening in #11027.
Changes
DescribableObjectTestswere duplicating the rig setup, causing subsequent tests in other packages to fail, introduced in Accessibility subsystem / describable object self-registration #11021 , tracked here DescribableObject tests break subsequent unit tests #11119System.Collections.Genericnamespace inDescribableObjectTestsuseRayVector = false, which causes thepointerRotation == deviceRotation, tracked by Changes to test harness hand ray math causes unit tests to break #11121AimAtutility method inTestHand, for easily aiming hand rays at objectsVerification
All unit tests pass.