Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rig origin changes break absolute-world-placed unit tests #11120

Closed
Zee2 opened this issue Oct 20, 2022 · 0 comments
Closed

Rig origin changes break absolute-world-placed unit tests #11120

Zee2 opened this issue Oct 20, 2022 · 0 comments

Comments

@Zee2
Copy link
Contributor

Zee2 commented Oct 20, 2022

This issue has been migrated a new MRTK repository, and the status of this issue will now be tracked at the following location:


Describe the bug

When #11035 changed the XR Rig to specify user height and origin offset explicitly, unit tests that expected y=0 for head height broke.

To reproduce

Run unit tests. Unit tests fail.

Expected behavior

Unit tests should not fail.

Fix

Objects in unit tests should be placed in head-height-relative reference frame.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants