Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint Node using-cards #1421

Closed
wants to merge 278 commits into from
Closed

Lint Node using-cards #1421

wants to merge 278 commits into from

Conversation

v-kydela
Copy link
Contributor

An addition to this already-merged PR: #1400

By request of @stevengum

johnataylor and others added 30 commits March 5, 2019 11:28
move LUIS call into helper and add child dialog for date
added ConversationState.Delete to OnTurnError
- use new Adapter Handler & MVC pattern
- use the new dialog structure
- use the FlightBooking LUIS model
- bump version to 0.3.0
- use new Activity Handler & MVC pattern
- use new class structure
- bump version to 0.3.0
…es" rather than "true"

- change property to use “true”
Fixes #853
minor clean up in Startup and better error handling
- get the metadata setup
- actual bot code yet to be updated.
johnataylor and others added 24 commits April 16, 2019 14:54
- update all nodejs samples
- update yeoman
- use syntax for lint script command that works cross platform
- delete a stray .bot file
-
- make script commands work cross platform
- bump version number of yeoman
- add ARM templates
- tweak README.md
…1412)

* Removed reference to deleted QnaWithAppInsights csproj from sln file

* Changed VS version to 15 for backward compat.
[JS][16.proactive-messages] Update for 4.3.4
* [JS][11.QnAMaker] Update for 4.3.4

* parity with C#

* - renamed .env variables
- added error handling for empty .env variables

* fixed comment that reference luis

* better parity with C#. Renamed variables, etc

* fixed README references to core-bot, PREREQs, LUIS

* implemented changes per @stevengum
@v-kydela
Copy link
Contributor Author

Oops wrong branch

@v-kydela v-kydela closed this Apr 20, 2019
@v-kydela v-kydela deleted the v-kydela/06-node-lint branch April 20, 2019 02:57
@v-kydela v-kydela restored the v-kydela/06-node-lint branch April 20, 2019 02:59
@stevengum stevengum deleted the v-kydela/06-node-lint branch April 23, 2019 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants