Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sample Address/Port Doesn't Match HTML Page's Instructions #1417

Closed
Zerryth opened this issue Apr 18, 2019 · 2 comments
Closed

Sample Address/Port Doesn't Match HTML Page's Instructions #1417

Zerryth opened this issue Apr 18, 2019 · 2 comments
Assignees
@sgellock
Labels
bug Indicates an unexpected problem or an unintended behavior.

Comments

@Zerryth
Copy link
Contributor

Zerryth commented Apr 18, 2019

Sample information

C# Samples in samples-work-in-progress branch

Describe the bug

Seems like the C# samples listen for a random localhost port now, and it doesn't match what the HTML page displays:

image

To Reproduce

Start up multiple C# samples and wait for the HTML page to pop up

Expected behavior

We should either

  1. ensure all of the samples start on 3978
    or
  2. dynamically pull the page address, and put it there

[bug]
@sgellock
Copy link
Member

@Zerryth all samples should default to 3978

@sgellock sgellock added 4.4 bug Indicates an unexpected problem or an unintended behavior. labels Apr 18, 2019
@sgellock sgellock self-assigned this Apr 18, 2019
sgellock added a commit that referenced this issue Apr 18, 2019
@sgellock
Fixes #1417 - Sample Address/Port Doesn't Match HTML Page's Instructions
9882cf6
@sgellock
Copy link
Member

all Properties/launchSettings.json files should be configured to use the 3978 ports. I've update the samples that haven't done this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgellock sgellock

Labels
bug Indicates an unexpected problem or an unintended behavior.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sgellock @Zerryth