Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lost SERVICE_ID request attribute with jdk http client. #11309

Merged
merged 1 commit into from
Nov 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import io.micronaut.core.propagation.PropagatedContext;
import io.micronaut.core.type.Argument;
import io.micronaut.core.util.StringUtils;
import io.micronaut.http.HttpAttributes;
import io.micronaut.http.HttpResponse;
import io.micronaut.http.HttpStatus;
import io.micronaut.http.MutableHttpRequest;
Expand Down Expand Up @@ -411,6 +412,10 @@ protected <O> Publisher<io.micronaut.http.HttpResponse<O>> responsePublisher(
@NonNull io.micronaut.http.HttpRequest<?> request,
@Nullable Argument<O> bodyType
) {
if (clientId != null && request.getAttribute(HttpAttributes.SERVICE_ID).isEmpty()) {
request.setAttribute(HttpAttributes.SERVICE_ID, clientId);
}

return Flux.defer(() -> mapToHttpRequest(request, bodyType)) // defered so any client filter changes are used
.map(httpRequest -> {
if (log.isDebugEnabled()) {
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,87 @@
package io.micronaut.http.client.jdk

import io.micronaut.context.ApplicationContext
import io.micronaut.context.annotation.Requires
import io.micronaut.http.HttpAttributes
import io.micronaut.http.HttpRequest
import io.micronaut.http.HttpResponse
import io.micronaut.http.HttpVersion
import io.micronaut.http.MutableHttpRequest
import io.micronaut.http.annotation.Controller
import io.micronaut.http.annotation.Filter
import io.micronaut.http.annotation.Get
import io.micronaut.http.client.HttpClientRegistry
import io.micronaut.http.client.annotation.Client
import io.micronaut.http.filter.ClientFilterChain
import io.micronaut.http.filter.HttpClientFilter
import io.micronaut.runtime.server.EmbeddedServer
import jakarta.inject.Singleton
import org.reactivestreams.Publisher
import spock.lang.AutoCleanup
import spock.lang.Specification

class ServiceIdSpec extends Specification {

@AutoCleanup
EmbeddedServer server = ApplicationContext.run(EmbeddedServer, [
'spec.name': 'ServiceIdSpec',
])

@AutoCleanup
ApplicationContext clientCtx = ApplicationContext.run([
'spec.name': 'ServiceIdSpec',
'micronaut.http.services.my-client-id.url': server.URI,
])

def 'service id set by declarative client'() {
given:
def client = clientCtx.getBean(DeclarativeClient)
def filter = clientCtx.getBean(ServiceIdFilter)

expect:
filter.serviceId == null
client.index() == "foo"
filter.serviceId == "my-client-id"
}

def 'service id set by normal client'() {
given:
def client = clientCtx.getBean(HttpClientRegistry).getClient(HttpVersion.HTTP_1_1, "my-client-id", null)
def filter = clientCtx.getBean(ServiceIdFilter)

expect:
filter.serviceId == null
client.toBlocking().exchange("/service-id", String).body() == "foo"
filter.serviceId == "my-client-id"
}

@Client(id = "my-client-id")
@Requires(property = "spec.name", value = "ServiceIdSpec")
static interface DeclarativeClient {
@Get("/service-id")
String index()
}

@Singleton
@Requires(property = "spec.name", value = "ServiceIdSpec")
@Controller("/service-id")
static class ServiceIdController {
@Get
def index(HttpRequest<?> request) {
return "foo"
}
}

@Singleton
@Requires(property = "spec.name", value = "ServiceIdSpec")
@Filter(Filter.MATCH_ALL_PATTERN)
static class ServiceIdFilter implements HttpClientFilter {
String serviceId

@Override
Publisher<? extends HttpResponse<?>> doFilter(MutableHttpRequest<?> request, ClientFilterChain chain) {
serviceId = request.getAttribute(HttpAttributes.SERVICE_ID).orElse(null)
return chain.proceed(request)
}
}
}
Loading