Add lost SERVICE_ID request attribute with jdk http client. #11309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yawkat do we have a TCK now for the client? Would be good to add a test to that if there is |
graemerocher
added
the
type: improvement
|
agreed |
|
Thanks! |
yawkat
added a commit
that referenced
this pull request
Nov 11, 2024
yawkat
added a commit
that referenced
this pull request
Jan 24, 2025
* Replace HttpAttributes with accessors Attributes are a suboptimal way of adding metadata to requests and responses, both because they need a string lookup, and because they require conversion. * migrate service id from #11309 * add since to deprecations * spotless * fix type pollution * fix sonar * merge * checkstyle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #11041