Add (optional) extra tags to mongo connection pool #2356
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is extremely useful for example to differentiate the connection pool in an application with multiple different connections to different databases which could be in the same server. resolves micrometer-metrics#2355
gustavomonarin
force-pushed
the
gh-2355-add-extra-tags-to-mongo-pool-metrics
branch
from
bef0823 to
3293edc
Compare
|
Hi @gustavomonarin , I had a similar pull request queued up (#2360) as it was initially built on top of another pending pull request. I saw this PR and since its in a close area I went ahead and submitted mine for the command listener so we can make sure they end up using similar mechanisms. I went w/ the tags provider approach for the command listener. You went w/ the extra tags approach. I asked this. Thanks |
|
Closing this PR in favor of #2437, as discussed with @bono007 that should make it more flexible and in line with more complex cases which could not fit by a static list of extra tags without contextual information (ie. data from the event itself). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is extremely useful for example to differentiate the connection pool in an application with multiple different connections to different databases which could be in the same mongo server.
resolves #2355