Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Mongo Connection pool tags provider #2355

Closed
gustavomonarin opened this issue Nov 21, 2020 · 0 comments · Fixed by #2437
Closed

Support for Mongo Connection pool tags provider #2355

gustavomonarin opened this issue Nov 21, 2020 · 0 comments · Fixed by #2437
Labels
enhancement A general enhancement
Milestone
1.7.0-M1

Comments

@gustavomonarin
Copy link
Contributor

gustavomonarin commented Nov 21, 2020 •
edited
Loading

This is especially important in applications which have multiple mongo connection pools, for example.

Thanks in advance, and great job/project!
gustavomonarin added a commit to gustavomonarin/micrometer that referenced this issue Nov 21, 2020
@gustavomonarin
Add (optional) extra tags to mongo connection pool
3293edc 
This is extremely useful for example to differentiate the connection pool in an application with multiple different connections to different databases which could be in the same server.

resolves micrometer-metrics#2355
@gustavomonarin gustavomonarin mentioned this issue Nov 21, 2020
Closed
@gustavomonarin gustavomonarin changed the title Support for extra tags for the mongo connection pull binder Support for extra tags for the mongo connection pool binder Nov 23, 2020
@gustavomonarin gustavomonarin mentioned this issue Nov 25, 2020
Closed
@shakuzen shakuzen added the enhancement A general enhancement label Jan 25, 2021
@shakuzen shakuzen added this to the 1.7.0 milestone Jan 25, 2021
@gustavomonarin gustavomonarin mentioned this issue Feb 7, 2021
Merged
@gustavomonarin gustavomonarin changed the title Support for extra tags for the mongo connection pool binder Support for Connection pool tags provider Feb 26, 2021
@shakuzen shakuzen modified the milestones: 1.7.0-M1, 1.7 backlog Mar 8, 2021
jonatan-ivanov added a commit to gustavomonarin/micrometer that referenced this issue Mar 15, 2021
@jonatan-ivanov
Merge branch 'master' into micrometer-metricsgh-2355-mongodb-connecti…
e2365ef 
…on-pool-tags-provider

# Conflicts:
#	micrometer-core/src/main/java/io/micrometer/core/instrument/binder/mongodb/MongoMetricsConnectionPoolListener.java
#	micrometer-core/src/test/java/io/micrometer/core/instrument/binder/mongodb/MongoMetricsConnectionPoolListenerTest.java
@shakuzen shakuzen modified the milestones: 1.7 backlog, 1.7.0-M1 Mar 16, 2021
@shakuzen shakuzen changed the title Support for Connection pool tags provider Support for Mongo Connection pool tags provider Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement A general enhancement
Projects
None yet
Milestone
1.7.0-M1
2 participants
@gustavomonarin @shakuzen