Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard expensive debug logging with isEnabledFor #358

Merged
merged 2 commits into from
Sep 29, 2024
Merged

Guard expensive debug logging with isEnabledFor #358

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac9abd3
Guard expensive debug logging with isEnabledFor
bdraco Sep 24, 2024
bee11e7
Merge branch 'master' into guard_debug
bdraco Sep 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions src/synology_dsm/synology_dsm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,14 +363,15 @@ async def _execute_request(
url_encoded, timeout=self._aiohttp_timeout, **kwargs
)

# mask sesitiv parameters
response_url = response.url # pylint: disable=E0606
for param in SENSITIV_PARAMS:
if params is not None and params.get(param):
response_url = response_url.update_query({param: "*********"})
self._debuglog("Request url: " + str(response_url))
self._debuglog("Response status_code: " + str(response.status))
self._debuglog("Response headers: " + str(dict(response.headers)))
# mask sesitive parameters
if _LOGGER.isEnabledFor(logging.DEBUG):
response_url = response.url # pylint: disable=E0606
for param in SENSITIV_PARAMS:
if params is not None and params.get(param):
response_url = response_url.update_query({param: "*********"})
self._debuglog("Request url: " + str(response_url))
self._debuglog("Response status_code: " + str(response.status))
self._debuglog("Response headers: " + str(dict(response.headers)))

if response.status == 200:
# We got a DSM response
Expand Down
Loading