Guard expensive debug logging with isEnabledFor #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that update_query rebuilds the whole query string every time so it would be a bit cleaner to call it once, however its probably not worth optimizing if its only going to be called when debug is on now
|
the failing tests are not related - they are caused by yarl 1.9.5 (with 1.9.4 it was working), the url does not contain the https default port 443 anymore (expected |
|
hi @bdraco , the tests are fixed now, please rebase your branch, thx 👍 |
|
Thanks @mib1185 Should be all set now |
mib1185
approved these changes
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that update_query rebuilds the whole query string every time so it would be a bit cleaner to call it once, however its probably not worth optimizing if its only going to be called when debug is on now